Add support for user defaults #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults if available
…ges to questions relating to user defaults in simple-ec2
…g, and other issues
Also clarify wording on subnet AZ question
cjerad
reviewed
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #75
Description of changes:
For each question in interactive mode, read the user default from
~/.simple-ec2/simple-ec2.jsonand prefer it to the system default wherever possible. This improves the user experience by suggesting defaults that they have previously chosen and thus may likely prefer now.This code was originally written by @GavinBurris42, and we conducted reviews on their fork: GavinBurris42#7 and GavinBurris42#8, where Gavin addressed extensive feedback from the team. I authored two additional commits for this PR: 791ed73 (
go mod tidy) and 051fe7c (refactor to extract a common function, error message wording clarification). This PR is to get the code into the main repo so we can release it publicly.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.