Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EndpointForcesSinusoidal used by joint examples #103

Closed
armantekinalp opened this issue Jun 1, 2022 · 0 comments · Fixed by #110
Closed

Refactor EndpointForcesSinusoidal used by joint examples #103

armantekinalp opened this issue Jun 1, 2022 · 0 comments · Fixed by #110
Assignees
@armantekinalp
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Version 0.3

Comments

@armantekinalp
Copy link
Contributor

We can move EndpointForcesSinusoidal inside the elastica.external_forces since there are test cases already defined for this class.

PyElastica/examples/JointCases/external_force_class_for_joint_test.py

Line 6 in 9e461aa

class EndpointForcesSinusoidal(NoForces):

@armantekinalp armantekinalp added enhancement New feature or request good first issue Good for newcomers labels Jun 1, 2022
@armantekinalp armantekinalp added this to the Version 0.3 milestone Jun 1, 2022
@armantekinalp armantekinalp changed the title Refactor external forces for joint examples Refactor EndpointForcesSinusoidal used by joint examples Jun 1, 2022
@armantekinalp armantekinalp mentioned this issue Jun 11, 2022
Merged
@armantekinalp armantekinalp self-assigned this Jun 11, 2022
@bhosale2 bhosale2 linked a pull request Jun 12, 2022 that will close this issue
refactor EndPointForcesSinusoidal example and test cases #110
Merged
pppprub pushed a commit to pppprub/PyElastica that referenced this issue Sep 4, 2022
@bhosale2
Merge pull request GazzolaLab#103 from bhosale2/91_fix_shear_coeff
fe15bf4 
Fix: Shear coefficient correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armantekinalp armantekinalp

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Version 0.3
Development

Successfully merging a pull request may close this issue.

refactor EndPointForcesSinusoidal example and test cases armantekinalp/PyElastica
2 participants
@skim0119 @armantekinalp