Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor EndPointForcesSinusoidal example and test cases #110

Conversation

armantekinalp
Copy link
Contributor

Fixes #103 . This fix is required for implementing pyproject for PyElastica.

@armantekinalp armantekinalp added the enhancement New feature or request label Jun 11, 2022
@armantekinalp armantekinalp requested a review from skim0119 June 11, 2022 20:37
@armantekinalp armantekinalp self-assigned this Jun 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (update-0.2.4@a511e49). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             update-0.2.4     #110   +/-   ##
===============================================
  Coverage                ?   87.21%           
===============================================
  Files                   ?       40           
  Lines                   ?     2557           
  Branches                ?      345           
===============================================
  Hits                    ?     2230           
  Misses                  ?      305           
  Partials                ?       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a511e49...b6fb6f7. Read the comment docs.

@bhosale2 bhosale2 linked an issue Jun 12, 2022 that may be closed by this pull request
Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mostly, 2 minor requests.

elastica/external_forces.py Outdated Show resolved Hide resolved
elastica/external_forces.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the EndpointForcesSinusoidal on the documentation?

@armantekinalp
Copy link
Contributor Author

I added documentation. Could you check again and then we can merge.

Copy link
Collaborator

@bhosale2 bhosale2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@skim0119 skim0119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skim0119 skim0119 merged commit 4ecd851 into GazzolaLab:update-0.2.4 Jun 17, 2022
@armantekinalp armantekinalp deleted the 103_refactor_EndpointForcesSinusoidal branch October 21, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor EndpointForcesSinusoidal used by joint examples
4 participants