-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor EndPointForcesSinusoidal example and test cases #110
refactor EndPointForcesSinusoidal example and test cases #110
Conversation
Codecov Report
@@ Coverage Diff @@
## update-0.2.4 #110 +/- ##
===============================================
Coverage ? 87.21%
===============================================
Files ? 40
Lines ? 2557
Branches ? 345
===============================================
Hits ? 2230
Misses ? 305
Partials ? 22 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mostly, 2 minor requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the EndpointForcesSinusoidal
on the documentation?
I added documentation. Could you check again and then we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #103 . This fix is required for implementing pyproject for PyElastica.