-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proper support for :named
smtlib annotations
#199
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclement-ocp
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me, I like the design of the Hook
capability. Just a few minor questions and comments.
This was referenced Nov 20, 2023
Closed
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Mar 8, 2024
We are not compatible with the development release of Dolmen due to the `implicit` field added in [1]. Further, we currently require that Dolmen move trigger annotations in SMT-LIB format from the body of the formula to the quantifier itself, but this was removed in [2]. Since both of these will be part of the next release of dolmen, let us pre-emptively ensure that release won't break Alt-Ergo. [1] : Gbury/dolmen#199 [2] : Gbury/dolmen#207
Halbaroth
pushed a commit
to OCamlPro/alt-ergo
that referenced
this pull request
Mar 13, 2024
We are not compatible with the development release of Dolmen due to the `implicit` field added in [1]. Further, we currently require that Dolmen move trigger annotations in SMT-LIB format from the body of the formula to the quantifier itself, but this was removed in [2]. Since both of these will be part of the next release of dolmen, let us pre-emptively ensure that release won't break Alt-Ergo. [1] : Gbury/dolmen#199 [2] : Gbury/dolmen#207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
:named
smtlib annotation has relatively annoying semantics. In particular, it implicitly introduces a global definition. Therefore this PR does a few things:Pipeline
transformation. This is because if we exploded them, then the intermediate typechecking state could be surprising to downstream pipes, since it would contain statements that these pipes have not yet seen.Hook
result for tags is added in the typechecker to allow for tags to arbitrarily change the typechecked term (instead of simply adding/setting some flags/tags in terms)core
theory of smtlib2 is adapted to use theHook
mechanism to properly replace named expression by their symbol, which is required since named expressions can be referred later by their symbol.