fix(build): Require dolmen 0.9 #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not compatible with the development release of Dolmen due to the `implicit` field added in [1]. Further, we currently require that Dolmen move trigger annotations in SMT-LIB format from the body of the formula to the quantifier itself, but this was removed in [2]. Since both of these will be part of the next release of dolmen, let us pre-emptively ensure that release won't break Alt-Ergo. [1] : Gbury/dolmen#199 [2] : Gbury/dolmen#207
|
Thanks :) |
bclement-ocp
added a commit
to bclement-ocp/opam-repository
that referenced
this pull request
Mar 20, 2024
… alt-ergo-lib (2.5.3) CHANGES: ### Build * Require dolmen 0.9 OCamlPro/alt-ergo#1050 * Test compatibility for OCaml 5.2 OCamlPro/alt-ergo#1059
bclement-ocp
added a commit
to bclement-ocp/opam-repository
that referenced
this pull request
Mar 20, 2024
… alt-ergo-lib (2.5.3) CHANGES: ### Build * Require dolmen 0.9 OCamlPro/alt-ergo#1050 * Test compatibility for OCaml 5.2 OCamlPro/alt-ergo#1059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are not compatible with the development release of Dolmen due to the
implicitfield added in Gbury/dolmen#199. Further, we currently require that Dolmen move trigger annotations in SMT-LIB format from the body of the formula to the quantifier itself, but this was removed in Gbury/dolmen#207.Since both of these will be part of the next release of dolmen, let us pre-emptively ensure that release won't break Alt-Ergo.
Note: this PR only makes sense for the
v2.5.xbranch. For thenextbranch, we already support Gbury/dolmen#199, and will adapt our code to support Gbury/dolmen#207 instead.