fix: nucleotide symbol equals with dot #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasKellerer
force-pushed
the
fixNucleotideEqualsWithDot
branch
from
db2d408
to
855a492
Compare
| @@ -7,7 +7,7 @@ TEST(NucleotideSymbol, enumShouldHaveSameLengthAsArrayOfSymbols) { | |||
| } | |||
|
|
|||
| TEST(NucleotideSymbol, conversionFromCharacter) { | |||
| EXPECT_EQ(silo::Nucleotide::charToSymbol('.'), silo::Nucleotide::Symbol::GAP); | |||
There was a problem hiding this comment.
Oh I see, it worked as the tests suggested, just the test was wrong 😄
|
I will now also add that the amino acid symbols are treated the same. (They give the correct result, but not explicitly by design.) |
|
@JonasKellerer great yes, amino acid syntax should be the same, |
JonasKellerer
force-pushed
the
fixNucleotideEqualsWithDot
branch
from
855a492
to
42ac7ce
Compare
|
There is now a new ticket #342 to revisit |
fengelniederhammer
added a commit
to GenSpectrum/LAPIS
that referenced
this pull request
Mar 6, 2024
fengelniederhammer
added a commit
to GenSpectrum/LAPIS
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From GenSpectrum/cov-spectrum-website#938
Summary
'.'should count if the symbol is equal to the reference genome. This PR should fix that.PR Checklist
- [ ] All necessary documentation has been adapted or there is an issue to do so.