Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filename of downloaded compressed files #685

Closed
chaoran-chen opened this issue Mar 3, 2024 · 1 comment · Fixed by #694
Closed

Fix filename of downloaded compressed files #685

chaoran-chen opened this issue Mar 3, 2024 · 1 comment · Fixed by #694
Assignees
@fengelniederhammer
Labels
bug Something isn't working

Comments

@chaoran-chen
Copy link
Member

When downloading a compressed file, the filename should indicate that it is a compressed file (i.e., end with .zstd or .gz). That's not the case at the moment:

image
@chaoran-chen chaoran-chen added the bug Something isn't working label Mar 3, 2024
@chaoran-chen chaoran-chen mentioned this issue Mar 3, 2024
Merged
1 task
@fengelniederhammer fengelniederhammer self-assigned this Mar 5, 2024
fengelniederhammer added a commit that referenced this issue Mar 5, 2024
@fengelniederhammer
refactor: split test class #685
84c0674
@fengelniederhammer
Copy link
Contributor

Actually it's implemented, but somehow broke during a recent change.

fengelniederhammer added a commit that referenced this issue Mar 5, 2024
@fengelniederhammer
fix: file ending when downloading compressed file #685
1c7a458 
also fix that LAPIS now correctly respects multiple, comma-separated values in the accept-encoding header.
fengelniederhammer added a commit that referenced this issue Mar 5, 2024
@fengelniederhammer
fix: file ending when downloading compressed file #685
c05c887 
also fix that LAPIS now correctly respects multiple, comma-separated values in the accept-encoding header.
fengelniederhammer added a commit that referenced this issue Mar 5, 2024
@fengelniederhammer
fix: file ending when downloading compressed file #685
2497b4d 
also fix that LAPIS now correctly respects multiple, comma-separated values in the accept-encoding header.
@fengelniederhammer fengelniederhammer mentioned this issue Mar 5, 2024
Merged
2 tasks
fengelniederhammer added a commit that referenced this issue Mar 5, 2024
@fengelniederhammer
fix: file ending when downloading compressed file #685
a01a804 
also fix that LAPIS now correctly respects multiple, comma-separated values in the accept-encoding header.
fengelniederhammer added a commit that referenced this issue Mar 6, 2024
@fengelniederhammer
fix: file ending when downloading compressed file #685
2bb8ccd 
also fix that LAPIS now correctly respects multiple, comma-separated values in the accept-encoding header.
fengelniederhammer added a commit that referenced this issue Mar 6, 2024
@fengelniederhammer
fix: test #685
33dad9e 
due to GenSpectrum/LAPIS-SILO#341
fengelniederhammer added a commit that referenced this issue Mar 6, 2024
@fengelniederhammer
refactor: split test class #685
f582b32
fengelniederhammer added a commit that referenced this issue Mar 6, 2024
@fengelniederhammer
fix: file ending when downloading compressed file #685
6a51de0 
also fix that LAPIS now correctly respects multiple, comma-separated values in the accept-encoding header.
fengelniederhammer added a commit that referenced this issue Mar 6, 2024
@fengelniederhammer
fix: test #685
f52d68d 
due to GenSpectrum/LAPIS-SILO#341
This was referenced May 6, 2024
Closed
Closed
Closed
Merged
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix filename of downloaded compressed files GenSpectrum/LAPIS
2 participants
@chaoran-chen @fengelniederhammer