fix: floatEquals and floatBetween with null values #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengelniederhammer
requested changes
Apr 30, 2024
JonasKellerer
force-pushed
the
investigateNullFloatFilterValue
branch
2 times, most recently
from
63526a2
to
4b33330
Compare
JonasKellerer
force-pushed
the
investigateNullFloatFilterValue
branch
from
dbe8107
to
4342175
Compare
- comparison with Nan was not implemented correctly
JonasKellerer
force-pushed
the
investigateNullFloatFilterValue
branch
from
4342175
to
a1ac821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In GenSpectrum/LAPIS#760 it was found that filtering for null values does not work correctly. This PR targets this issue. The problem was that null is represented as nan in the code. However, equals comparisons with nan always return false.
PR Checklist
- [ ] All necessary documentation has been adapted or there is an issue to do so.