feat: allow filtering for null #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currrently this PR is waiting on SILO to handle null values in float filters. |
|
@fengelniederhammer Do we want to explicitly show in Swagger that null is a valid filter value? |
JonasKellerer
force-pushed
the
757-filter-by-null-values
branch
from
c15eeef
to
1a58e67
Compare
Would be good, does Swagger have good support for nullable types? Or is it that "not required" means "nullable" in Swagger? |
This was referenced Apr 30, 2024
JonasKellerer
force-pushed
the
757-filter-by-null-values
branch
from
82a8e61
to
72b426a
Compare
JonasKellerer
force-pushed
the
757-filter-by-null-values
branch
3 times, most recently
from
e4d31ce
to
2795e76
Compare
fengelniederhammer
requested changes
May 2, 2024
lapis2/src/test/kotlin/org/genspectrum/lapis/model/SiloFilterExpressionMapperTest.kt
Outdated
Show resolved
Hide resolved
lapis2/src/test/kotlin/org/genspectrum/lapis/silo/SiloQueryTest.kt
Outdated
Show resolved
Hide resolved
lapis2/src/main/kotlin/org/genspectrum/lapis/model/SiloFilterExpressionMapper.kt
Show resolved
Hide resolved
fengelniederhammer
approved these changes
May 7, 2024
lapis2/src/main/kotlin/org/genspectrum/lapis/model/SiloFilterExpressionMapper.kt
Outdated
Show resolved
Hide resolved
JonasKellerer
force-pushed
the
757-filter-by-null-values
branch
from
6f64c53
to
7bfac55
Compare
- except pango lineage wip: swagger ui
JonasKellerer
force-pushed
the
757-filter-by-null-values
branch
from
7bfac55
to
0e05988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #757
Description
Allows all filters in GET and POST requests to be null (except pango lineage)
PR Checklist