Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pango lineage filter with null values #403

Merged
merged 1 commit into from
May 2, 2024

Conversation

JonasKellerer
Copy link
Contributor

Summary

In GenSpectrum/LAPIS#760 it was found that filtering for null values does not work correctly. This PR targets this issue. The problem was that null was not allowed for pangolineage filters.

PR Checklist

- [ ] All necessary documentation has been adapted or there is an issue to do so.

  • The implemented feature is covered by an appropriate test.

@JonasKellerer JonasKellerer force-pushed the investigateNullPangoLineageFilterValue branch from a27a18c to 0b604bb Compare May 2, 2024 06:46
Copy link
Contributor

@fengelniederhammer fengelniederhammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/silo/test/pango_lineage_filter.test.cpp Outdated Show resolved Hide resolved
src/silo/test/pango_lineage_filter.test.cpp Outdated Show resolved Hide resolved
@JonasKellerer JonasKellerer force-pushed the investigateNullPangoLineageFilterValue branch from 0b604bb to 35dc0c7 Compare May 2, 2024 10:01
@JonasKellerer JonasKellerer merged commit b7238a8 into main May 2, 2024
8 checks passed
@JonasKellerer JonasKellerer deleted the investigateNullPangoLineageFilterValue branch May 2, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants