Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/sample path #501

Closed
chaoran-chen opened this issue Dec 14, 2023 · 0 comments · Fixed by #503
Closed

/sample path #501

chaoran-chen opened this issue Dec 14, 2023 · 0 comments · Fixed by #503
Assignees
@fengelniederhammer
Labels
LAPIS Tasks/PR related to LAPIS
Milestone
COVID-LAPIS

Comments

@chaoran-chen
Copy link
Member

chaoran-chen commented Dec 14, 2023 •
edited
Loading

We should add /sample as a path prefix again, i.e., having /sample/aggregated instead of just /aggregated. At the moment, we only have this one entity in LAPIS but we should keep open the possibility that LAPIS at some point will have a wider scope and more than just "sample".
@chaoran-chen chaoran-chen added the LAPIS Tasks/PR related to LAPIS label Dec 14, 2023
@chaoran-chen chaoran-chen added this to the COVID-LAPIS milestone Dec 14, 2023
@fengelniederhammer fengelniederhammer self-assigned this Dec 14, 2023
fengelniederhammer added a commit that referenced this issue Dec 14, 2023
@fengelniederhammer
feat: add /sample to query paths #501
60ad1a6
@fengelniederhammer fengelniederhammer mentioned this issue Dec 14, 2023
Merged
fengelniederhammer added a commit that referenced this issue Dec 14, 2023
@fengelniederhammer
feat: add /sample to query paths #501
a401a9d
fengelniederhammer added a commit that referenced this issue Dec 14, 2023
@fengelniederhammer
feat: add /sample to query paths #501
7ad9746
This was referenced May 6, 2024
Closed
Closed
Merged
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
LAPIS Tasks/PR related to LAPIS
Projects
None yet
Milestone
COVID-LAPIS
Development

Successfully merging a pull request may close this issue.

feat: add /sample to query paths GenSpectrum/LAPIS
2 participants
@chaoran-chen @fengelniederhammer