Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloadAsFile parameter #599

Closed
chaoran-chen opened this issue Jan 26, 2024 · 0 comments · Fixed by #605
Closed

downloadAsFile parameter #599

chaoran-chen opened this issue Jan 26, 2024 · 0 comments · Fixed by #605
Assignees
@fengelniederhammer
Labels
LAPIS Tasks/PR related to LAPIS
Milestone
COVID-LAPIS

Comments

@chaoran-chen
Copy link
Member

chaoran-chen commented Jan 26, 2024 •
edited
Loading

The same as #26, just for v2.

The filename of the downloaded file should be sensible (compare 95ba6d0#diff-c17d35b23549a3aa75a4c0cc6cd5b464c65b56769a7d85c6bac15ae9f3da66dbR110)
@chaoran-chen chaoran-chen added the LAPIS Tasks/PR related to LAPIS label Jan 26, 2024
@chaoran-chen chaoran-chen added this to the COVID-LAPIS milestone Jan 26, 2024
@chaoran-chen chaoran-chen mentioned this issue Jan 28, 2024
Closed
@fengelniederhammer fengelniederhammer self-assigned this Jan 29, 2024
fengelniederhammer added a commit that referenced this issue Jan 29, 2024
@fengelniederhammer
feat: implement downloadAsFile #599
bcec50e
@fengelniederhammer fengelniederhammer mentioned this issue Jan 29, 2024
Merged
1 task
fengelniederhammer added a commit that referenced this issue Jan 29, 2024
@fengelniederhammer
feat: implement downloadAsFile #599
de63fe1
fengelniederhammer added a commit that referenced this issue Jan 30, 2024
@fengelniederhammer
feat: implement downloadAsFile #599
3b0d584
fengelniederhammer added a commit that referenced this issue Jan 30, 2024
@fengelniederhammer
feat: implement downloadAsFile #599
c522296
This was referenced May 6, 2024
Closed
Closed
Merged
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
LAPIS Tasks/PR related to LAPIS
Projects
None yet
Milestone
COVID-LAPIS
Development

Successfully merging a pull request may close this issue.

feat: implement downloadAsFile GenSpectrum/LAPIS
2 participants
@chaoran-chen @fengelniederhammer