fix: return valid gzip when LAPIS returns an error response #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the following happened: * The gzip stream eagerly writes the gzip header to the underlying stream (in its constructor) * an error occurs * Spring's error handling resets the response buffer (erasing the gzip header) * The exception handler writes a messages, which gets gzip compressed. Fix by: Delay initializing the gzip output stream until something is written to it.
fengelniederhammer
force-pushed
the
656-bad-request-returns-invalid-gzip-compressed-data
branch
from
1769fae
to
e5eaeff
Compare
fengelniederhammer
deleted the
656-bad-request-returns-invalid-gzip-compressed-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the following happened:
Fix by: Delay initializing the gzip output stream until something is written to it.
resolves #656
PR Checklist
[ ] All necessary documentation has been adapted.