Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad request returns invalid gzip compressed data #656

Closed
fengelniederhammer opened this issue Feb 20, 2024 · 1 comment · Fixed by #657
Closed

bad request returns invalid gzip compressed data #656

fengelniederhammer opened this issue Feb 20, 2024 · 1 comment · Fixed by #657
Assignees
@fengelniederhammer
Labels
bug Something isn't working LAPIS Tasks/PR related to LAPIS
Milestone
COVID-LAPIS

Comments

@fengelniederhammer
Copy link
Contributor

Apparently, when SILO returns a 400 and LAPIS was requested to return compressed data, LAPIS sends out compressed data, but not the corresponding header. Investigate and eventually fix.
@fengelniederhammer fengelniederhammer added bug Something isn't working LAPIS Tasks/PR related to LAPIS labels Feb 20, 2024
@fengelniederhammer fengelniederhammer self-assigned this Feb 20, 2024
@fengelniederhammer fengelniederhammer changed the title bad request - compressed bad request returns invalid gzip compressed data Feb 20, 2024
fengelniederhammer added a commit that referenced this issue Feb 20, 2024
@fengelniederhammer
fix: return valid gzip when LAPIS returns an error response #656
8cb7f6e 
Apparently the following happened:
* The gzip stream eagerly writes the gzip header to the underlying stream (in its constructor)
* an error occurs
* Spring's error handling resets the response buffer (erasing the gzip header)
* The exception handler writes a messages, which gets gzip compressed.

Fix by: Delay initializing the gzip output stream until something is written to it.
@fengelniederhammer
Copy link
Contributor Author

Observations:

  • Zstd works correctly
  • Gzip doesn't
  • When sending a request that returns an error, then the response is not valid gzip data. At least the gzip header (the magic bytes) are missing

fengelniederhammer added a commit that referenced this issue Feb 20, 2024
@fengelniederhammer
fix: return valid gzip when LAPIS returns an error response #656
1769fae 
Apparently the following happened:
* The gzip stream eagerly writes the gzip header to the underlying stream (in its constructor)
* an error occurs
* Spring's error handling resets the response buffer (erasing the gzip header)
* The exception handler writes a messages, which gets gzip compressed.

Fix by: Delay initializing the gzip output stream until something is written to it.
@fengelniederhammer fengelniederhammer mentioned this issue Feb 20, 2024
Merged
1 task
fengelniederhammer added a commit that referenced this issue Feb 20, 2024
@fengelniederhammer
fix: return valid gzip when LAPIS returns an error response #656
e5eaeff 
Apparently the following happened:
* The gzip stream eagerly writes the gzip header to the underlying stream (in its constructor)
* an error occurs
* Spring's error handling resets the response buffer (erasing the gzip header)
* The exception handler writes a messages, which gets gzip compressed.

Fix by: Delay initializing the gzip output stream until something is written to it.
@fengelniederhammer fengelniederhammer added this to the COVID-LAPIS milestone Feb 21, 2024
fengelniederhammer added a commit that referenced this issue Feb 21, 2024
@fengelniederhammer
fix: return valid gzip when LAPIS returns an error response #656
db1c6cb 
Apparently the following happened:
* The gzip stream eagerly writes the gzip header to the underlying stream (in its constructor)
* an error occurs
* Spring's error handling resets the response buffer (erasing the gzip header)
* The exception handler writes a messages, which gets gzip compressed.

Fix by: Delay initializing the gzip output stream until something is written to it.
This was referenced May 6, 2024
Closed
Closed
Merged
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
bug Something isn't working LAPIS Tasks/PR related to LAPIS
Projects
None yet
Milestone
COVID-LAPIS
Development

Successfully merging a pull request may close this issue.

fix: return valid gzip when LAPIS returns an error response GenSpectrum/LAPIS
1 participant
@fengelniederhammer