Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement a request cache for mutation and insertion queries #681

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

fengelniederhammer
Copy link
Contributor

Also make sure to invalidate the cache when SILO has a new data version

resolves #137

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@chaoran-chen
Copy link
Member

@fengelniederhammer, it just came to my mind (in case you haven't considered it already): if the query asks for a random order, the result may not be cached.

@fengelniederhammer
Copy link
Contributor Author

Thanks for the reminder! I added a comment to #658

Also make sure to invalidate the cache when SILO has a new data version
Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we somehow test whether the cache is invalidated when a new data version is available?

Also do we need to add some docu?

@fengelniederhammer
Copy link
Contributor Author

There is SiloClientAndCacheInvalidatorTest in SiloClientTest.kt that checks tests this: populate the cache with some data version, set the SILO mock to return a new data version and check that the next time, the cache isn't hit.

I'll do the docs in a separate PR.

@fengelniederhammer fengelniederhammer merged commit 17ff89c into main Mar 4, 2024
10 checks passed
@fengelniederhammer fengelniederhammer deleted the 137-implement-a-request-cache branch March 4, 2024 12:06
@fengelniederhammer fengelniederhammer mentioned this pull request Mar 4, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a request cache
3 participants