Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a request cache #137

Closed
fengelniederhammer opened this issue Feb 22, 2023 · 4 comments · Fixed by #681
Closed

Implement a request cache #137

fengelniederhammer opened this issue Feb 22, 2023 · 4 comments · Fixed by #681
Assignees
@fengelniederhammer
Labels
LAPIS Tasks/PR related to LAPIS

Comments

@fengelniederhammer
Copy link
Contributor

fengelniederhammer commented Feb 22, 2023 •
edited by JonasKellerer
Loading

Cache requests to reduce load on SILO.

Details:

  • the cache should be invoked for:
    • /nucleotideMutations
    • /aminoAcidMutations
    • /nucleotideInsertions
    • /aminoAcidInsertions
  • other routes should be ignored
  • when a new data version is available the cache should be invalidated
@fengelniederhammer fengelniederhammer added epic Collection of multiple issues for a larger feature LAPIS Tasks/PR related to LAPIS labels Feb 22, 2023
@JonasKellerer
Copy link
Contributor

Do we still plan on doing this? It seems, that SILO can handle large number of requests. Or do we keep this open, until we see the results from the production server?

@chaoran-chen
Copy link
Member

Yes, let's keep it for a while and then analyze the response times.

@fengelniederhammer fengelniederhammer mentioned this issue Feb 29, 2024
Closed
@JonasKellerer
Copy link
Contributor

As discussed, we will now introduce a request cache, similar to v1.

This is necessary, due to large load on SILO (mainly on the collections page.) See GenSpectrum/LAPIS-SILO#298

@JonasKellerer
Copy link
Contributor

I updated the description.

@JonasKellerer JonasKellerer removed the epic Collection of multiple issues for a larger feature label Feb 29, 2024
fengelniederhammer added a commit that referenced this issue Mar 1, 2024
@fengelniederhammer
feat: implement a request cache for mutation and insertion queries #137
9d51191
fengelniederhammer added a commit that referenced this issue Mar 1, 2024
@fengelniederhammer
fixup! feat: implement a request cache for mutation and insertion que…
e9781d4 
…ries #137
fengelniederhammer added a commit that referenced this issue Mar 1, 2024
@fengelniederhammer
feat: implement a request cache for mutation and insertion queries #137
92146b6 
Also make sure to invalidate the cache when SILO has a new data version
@fengelniederhammer fengelniederhammer mentioned this issue Mar 1, 2024
Merged
1 task
fengelniederhammer added a commit that referenced this issue Mar 1, 2024
@fengelniederhammer
feat: implement a request cache for mutation and insertion queries #137
945ab98 
Also make sure to invalidate the cache when SILO has a new data version
fengelniederhammer added a commit that referenced this issue Mar 1, 2024
@fengelniederhammer
feat: implement a request cache for mutation and insertion queries #137
b3668ad 
Also make sure to invalidate the cache when SILO has a new data version
fengelniederhammer added a commit that referenced this issue Mar 4, 2024
@fengelniederhammer
feat: implement a request cache for mutation and insertion queries #137
17ff89c 
Also make sure to invalidate the cache when SILO has a new data version
fengelniederhammer added a commit that referenced this issue Mar 4, 2024
@fengelniederhammer
feat(docs): document that there is a cache now #137
d30cf6d
fengelniederhammer added a commit that referenced this issue Mar 4, 2024
@fengelniederhammer
feat(docs): document that there is a cache now #137
597a471
@fengelniederhammer fengelniederhammer mentioned this issue Mar 4, 2024
Merged
1 task
fengelniederhammer added a commit that referenced this issue Mar 4, 2024
@fengelniederhammer
feat(docs): document that there is a cache now #137
88906a4
This was referenced May 6, 2024
Closed
Closed
Closed
Merged
@github-actions github-actions bot mentioned this issue Aug 26, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fengelniederhammer fengelniederhammer

Labels
LAPIS Tasks/PR related to LAPIS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement a request cache for mutation and insertion queries GenSpectrum/LAPIS
3 participants
@chaoran-chen @fengelniederhammer @JonasKellerer