-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests to use dvc-tracked baseline images #1131
Labels
Milestone
Comments
5 tasks
5 tasks
5 tasks
michaelgrund
added a commit
that referenced
this issue
Mar 29, 2021
As discussed in #1131, this PR moves the reference figures in fig.contour to use dvc.
This was referenced Apr 1, 2021
5 tasks
This was referenced Apr 2, 2021
5 tasks
5 tasks
This was referenced Apr 3, 2021
5 tasks
This was referenced Apr 11, 2021
weiji14
added a commit
that referenced
this issue
May 26, 2021
Final round of tests to migrate to DVC for the `grdview` plotting module. This is related to #1131, and is almost like reverting #589 actually. * Migrate test_grdview baseline images to dvc * Update fig.grdview baseline images for GMT 6.2.0rc1 * Plot fancy frame for test_grdview_with_perspective * Update fig.grdview baseline images for GMT 6.2.0rc2 * Use projection="Q15c+" for test_grdview_with_perspective
9 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this issue
Dec 21, 2022
Final round of tests to migrate to DVC for the `grdview` plotting module. This is related to GenericMappingTools#1131, and is almost like reverting GenericMappingTools#589 actually. * Migrate test_grdview baseline images to dvc * Update fig.grdview baseline images for GMT 6.2.0rc1 * Plot fancy frame for test_grdview_with_perspective * Update fig.grdview baseline images for GMT 6.2.0rc2 * Use projection="Q15c+" for test_grdview_with_perspective
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
After #1036, we start to use the new
dvc
based workflow for baseline images. We need to migrate existing baseline images to dvc, and also rewrite some tests. Please read the Testing Plots section in the contributing guides for the details of the newdvc
based workflow. (Related to #963)This issue tracks the progress of the migration.
Main Tasks
@check_figures_equal
tests to@pytest.mark.mpl_image_compare
Migrate existing baseline images to dvc
For each item, you should see the test file
pygmt/tests/test_xxx.py
and baseline imagespygmt/tests/baseline/test_xxx_*.png
.pygmt/tests/test_figure.py
) (Migrate test_figure_shift_origin to dvc #1133, @seisman)Migrate
@check_figures_equal
tests to@pytest.mark.mpl_image_compare
Some tests in the following files use
@check_figures_equal
, and should be migrated to@pytest.mark.mpl_image_compare
.Here are some notes for the migration based on my own experience. These are all open for comments and suggestions:
The text was updated successfully, but these errors were encountered: