-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Figure.subplot tests to dvc #1170
Conversation
Related to #1131.
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)
Report last updated at commit 7513b6c |
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Btw, we should teach you about making batch changes to save on a few clicks. See https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes. You can go to the 'Files' tab on the GitHub UI and click on 'Add suggestion to batch'. |
Thanks for mentioning @weiji14, didn't know that so far 😄. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @michaelgrund, feel free to merge this in yourself. I've disabled the 'Docs' CI test requirement (since they don't run on changes to `pygmt/tests/*') so you should be able to merge it in straight this time.
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Description of proposed changes
Related to #1131.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version