Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESWN: Add common options to PyGMT functions and methods #1445

Closed
14 tasks done
maxrjones opened this issue Aug 17, 2021 · 4 comments · Fixed by #1519
Closed
14 tasks done

ESWN: Add common options to PyGMT functions and methods #1445

maxrjones opened this issue Aug 17, 2021 · 4 comments · Fixed by #1519
Labels
eswn-workshop Good issues for first-contributions during the ESWN-PyGMT workshop feature request New feature wanted good first issue Good for newcomers help wanted Helping hands are appreciated
Milestone

Comments

@maxrjones
Copy link
Member

maxrjones commented Aug 17, 2021

Description of the desired feature

There are some common options from GMT that are missing from the corresponding PyGMT functions and methods. This issue tracks adding the common options to the following methods:

Are you willing to help implement and maintain this feature? Glad to help people with PRs!

@maxrjones
Copy link
Member Author

@michaelgrund, thanks for submitting the PR! I'm going to guide the participants in the ESWN workshop tomorrow through the remainder of the tasks (i.e. adding the other common options), and it will be helpful for them to use your PR as an example!

@maxrjones maxrjones added eswn-workshop Good issues for first-contributions during the ESWN-PyGMT workshop good first issue Good for newcomers labels Aug 17, 2021
@michaelgrund
Copy link
Member

Great idea @meghanrjones 👍.

@weiji14 weiji14 pinned this issue Aug 18, 2021
@weiji14 weiji14 changed the title Add common options to PyGMT functions and methods ESWN: Add common options to PyGMT functions and methods Aug 18, 2021
@maxrjones maxrjones added the help wanted Helping hands are appreciated label Aug 19, 2021
@weiji14 weiji14 unpinned this issue Sep 10, 2021
michaelgrund added a commit that referenced this issue Sep 12, 2021
This PR adds the common options coltypes, transparency and wrap to the pygmt.Figure.wiggle method.

Addresses #1445
@maxrjones
Copy link
Member Author

@michaelgrund FYI I just unassigned plot/plot3d from the workshop list if you want to wrap this issue up (no pressure though).

@maxrjones
Copy link
Member Author

I forgot to include instructions for updating the kwargs_to_strings with the addition of g and o. I will submit a single PR fixing this, which should be the end of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eswn-workshop Good issues for first-contributions during the ESWN-PyGMT workshop feature request New feature wanted good first issue Good for newcomers help wanted Helping hands are appreciated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants