Fix common options in blockm, surface, histogram, rose, and grdtrack #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel it's better to split the changes into two separate PRs. |
maxrjones
changed the title
maxrjones
changed the title
seisman
reviewed
Sep 19, 2021
Co-authored-by: Dongdong Tian <seisman@users.noreply.github.com>
seisman
approved these changes
Sep 19, 2021
seisman
added
final review call
maxrjones
removed
the
final review call
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…enericMappingTools#1519) * Remove -g gap from histogram, rose * Add -i incols to histogram * Remove -s skiprows from blockm.py, surface * Add -a aspatial to grdtrack Co-authored-by: Dongdong Tian <seisman@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR fixes some erroneous additions from #1445 and prior PRs based on fixes made to GMT in GenericMappingTools/gmt#5759. Here is the detailed list:
-
skiprowsno longer in blockmean, blockmedian, blockmode, surface (not supported)-
gapno longer in histogram, rose (not supported)-
aspatialnow documented in grdtrack-
incolsnow documented in histogramCloses #1445
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version