Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect ghostscript and default image viewer in FreeBSD #878

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 12, 2021

Description of proposed changes

Better FreeBSD support after #700.

Address the comment https://github.com/GenericMappingTools/pygmt/pull/529/files#r560669482.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the enhancement Improving an existing feature label Feb 12, 2021
@seisman seisman added this to the 0.3.0 milestone Feb 12, 2021
@seisman seisman requested a review from weiji14 February 12, 2021 21:18
pygmt/helpers/utils.py Outdated Show resolved Hide resolved
pygmt/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@weiji14 weiji14 changed the title Better FreeBSD support Better detection of ghostscript and default image viewer in FreeBSD Feb 12, 2021
@weiji14 weiji14 changed the title Better detection of ghostscript and default image viewer in FreeBSD Detect ghostscript and default image viewer in FreeBSD Feb 12, 2021
@seisman seisman merged commit 65c6e27 into master Feb 12, 2021
@seisman seisman deleted the freebsd branch February 12, 2021 22:51
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…gTools#878)

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants