add triple lift #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjung
pushed a commit
that referenced
this pull request
Feb 12, 2020
* Rivr thin adapter (#5) * RVR-2049 - change impression event * RVR-2049 - fix user id value returned on creation of the cookie * RVR-2049 - remove blockedCategories and browser properties from Auction object * RVR-2060 - rewrite rendering detection for impression and click events * RVR-2060 - rewrite tests for rendering detection for impression and click events * RVR-2049 - send ad unit code in click event * RVR-2049 - adapt tests for click event * RVR-2072 - split impression detection depending on the ad server - DFP/none * RVR-2056 - set creativeId in Auction -> received bids * RVR-2056 - set bid.clearPrice to cmp * RVR-2087 - extract trackAuctionInit implementation to rivraddon * RVR-2087 - extract implementation to rivraddon WIP * RVR-2087 - extract implementation to rivraddon * RVR-2087 - extract implementation to rivraddon * RVR-2087 - Update package-lock * RVR-2087 - Add addons check * Rivr Thin Adapter - part 2 (#6) * RVR-2087 - Remove sendAuction call from ExpiringQueue * RVR-2147 - Fix test failing on IE 11.0.0 * RVR-2087 - Remove ExpiringQueue
trivedi
pushed a commit
that referenced
this pull request
Aug 13, 2020
* First implementation of the AdRoll adapter (#1) * Fix request and bid id (#5) * Send Zone ID (#6) * Add age check before fastbid eval (#7) * Add age check before fastbid eval * Fix linting * Add date check (#8) * Add date exists check * Remove logging statement * Fix bidRequest validation (#9) * Fix deprecated function usage (prebid#10) * [SENG-2757] remove custom function from adapter (prebid#11) * remove loadExternalScript function * add adroll to the adloader whitelist * Handle nextroll id (prebid#12) * Handle nextroll id * Remove double nesting in user obj * Revert change to publisherTagAvailable * Rename adroll -> nextroll (prebid#14) * Rename fastbid -> pubtag functions and variables (prebid#15) * Improve coverage of tests * Add docs * Add docs * Improve sizes and add sellerid * Add maintainer email * Fix CI problem * Fix IE tests * Replace second instance of find * Fix types used in the doc Match prebid/prebid.github.io#1796 * Remove unused fields in spec * Add ccpa support * Remove external script usage * Remove IP field * Remove pubtag key * Rename imports; Remove getUserSync function; Remove unused code; Use url.parse function Co-authored-by: Juan Bono <juanbono94@gmail.com> Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
Other information