Dissociate virtual display size and capture size #5506
Merged
+35
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2024
|
i tried it out and it works just fine, thank you rom1v. are you going to merge this? |
👍 Thank you for the test!
Yes. |
Allow capturing virtual displays at a lower resolution using -m/--max-size. In the original implementation in #5370, the virtual display size was necessarily the same as the capture size. The --max-size value was only allowed to determine the virtual display size when no explicit size was provided. Since the dpi was scaled down accordingly, it is often better to create a virtual display at the target capture size directly. However, not everything is rendered according to the virtual display DPI. For example, a page in Firefox is rendered too big on small virtual displays. Thus, it makes sense to be able create a virtual display at a given size, and capture it at a lower resolution with --max-size. This is now possible using OpenGL filters. Therefore, change the behavior of --max-size for virtual displays: - --max-size does not impact --new-display without size argument anymore (the virtual display size is the main display size); - it is used to limit the capture size (whether an explicit size is provided or not). This new behavior is consistent with main display capture. Refs #5370 comment <#5370 (comment)> Refs #5370 <#5370> PR #5506 <#5506>
rom1v
force-pushed
the
new_display_resize
branch
from
daba00a
to
264110f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow capturing virtual displays at a lower resolution using
-m/--max-size.In the original implementation in #5370, the virtual display size was necessarily the same as the capture size. The
--max-sizevalue was only allowed to determine the virtual display size when no explicit size was provided.Since the dpi was scaled down accordingly, it is often better to create a virtual display at the target capture size directly. However, not everything is rendered according to the virtual display DPI. For example, a page in Firefox is rendered too big on small virtual displays. Thus, it makes sense to be able create a virtual display at a given size, and capture it at a lower resolution with
--max-size. This is now possible using OpenGL filters.Therefore, change the behavior of
--max-sizefor virtual displays:--new-displaywithout size argument anymore (the virtual display size is the main display size);This new behavior is consistent with main display capture.
@Withoutruless This is the behavior you requested here: #5370 (comment)
scrcpy-win64-pr5506.zipSHA-256: 7d4b7451fd56820b64bd33060137b7a44391979318a5c82db67c33ad7354943