Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smtc sm recorder swap #2010

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Smtc sm recorder swap #2010

merged 2 commits into from
Mar 27, 2024

Conversation

Thomas-Benson
Copy link
Contributor

  • Removing CSI EQR120 (46531) from SMTC LC 20
  • Replacing with EQR120 (46628) at same location
  • New EQR120 running latest firmware version 2.3.2
  • Using same orientation 0/N as previous recorder

@Thomas-Benson Thomas-Benson self-assigned this Mar 26, 2024
@Thomas-Benson Thomas-Benson requested review from ozym and a team as code owners March 26, 2024 22:50
mnaguit
mnaguit reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@mnaguit mnaguit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

special case when axial flag is true but azimuth is 0?

@Thomas-Benson
Copy link
Contributor Author

This site was originally installed at 182. When the sensor was replaced in march 2021 the orientation was change to true north, but it looks like a decision was made then to keep the stream names as axial since this isn't a free field site.

@CBurton90
Copy link
Contributor

@mnaguit Again we are trying to standardize what to do in this scenario. I'm pretty sure we are all in agreement with this guide (after many discussions + delta meetings with this problem):

#1967

This PR matches that guide.

@mnaguit
Copy link
Contributor

mnaguit commented Mar 27, 2024

Okidoki...a special case then. 😄 Thank you Gentlemen!

@Thomas-Benson Thomas-Benson merged commit 722c607 into main Mar 27, 2024
18 checks passed
@Thomas-Benson Thomas-Benson deleted the SMTC-SM-recorder-swap branch March 27, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnaguit mnaguit mnaguit approved these changes

@CBurton90 CBurton90 CBurton90 approved these changes

@salichon salichon Awaiting requested review from salichon

@gva6500 gva6500 Awaiting requested review from gva6500

@ozym ozym Awaiting requested review from ozym ozym is a code owner

Assignees

@Thomas-Benson Thomas-Benson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thomas-Benson @CBurton90 @mnaguit