-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Westmelton2 GeoMag equipment update #2025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hei @TurnerDave , this is a new site, and will require a bunch of more metadata to be added on delta before this pull request can be merged.
The complete set of files that need to include geomag metadata is:
- network/stations.csv (geomag has network code = GM)
- network/sites.csv (geomag has channel code = 50 for the fluxgate and 51 for the proton)
- calibrations/fluxgate : a text file with Danish Met Insitute calibration results for individual fluxgate sensor and driver
- assets/dataloggers.csv
- assets/recorders.csv
- assets/sensors.csv
- install/calibrations.csv
- install/channels.csv (check that model is there)
- install/components.csv (check that model and response file is there)
- install/connections.csv
- install/dataloggers.csv
- install/gains.csv
- install/recorders.csv
- install/sensors.csv
- install/streams.csv
- resp/files (check model is there)
Thanks @elidana I have no idea what I'm doing, so I really appreciate your guidance. I'll update the field you listed :) |
@elidana check-list completed and changes made where required. Thank you for your help. |
Note that I need to confirm the correct install/gains.csv values following feedback from Mark C. Will re-submit once updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done on wrangling this! some more comments and tweaks
A couple of general comments (in addition to the more detailed in line ones)
- is there a calibration file for this sensor? If so, can we please add it to the
calibration/fluxgates
folder. This is usually a copy of the calibration PDF received by the Danish Met Institute, file name has the same serial number used here - In general, the station name needs to be consistent across different files. I propose to use
West Melton Geomagnetic Observatory 2
orWest Melton 2 Geomagnetic Observatory
everywhere
see also other more detailed comments
@elidana We're getting there. All points above addressed and ready for review. Thanks for your patience :) |
|
@elidana I should have questioned adding the pdf, as the other sensors didn't have their calibration certs uploaded. I now have a problem that I can't delete the pdf from the pull request. The option to delete the file is greyed-out. I can delete the entire directory, but not that file inside of it. Any ideas? I don't really want to delete the pull request and start again. |
c498833
to
4fabf2d
Compare
ok, I did some tweaks on this pr
all tests are now passing |
@CBurton90 or @gva6500 can you please review this from the RIM team perspective? @ozym , this is a new site. I can see already miniseed data poppinp up in the archive, but would be great if you can double check that this is complete! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
passes the tests and has the gain settings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks for your efforts here @TurnerDave
4fabf2d
to
7ec5251
Compare
install times updated to reflect first data in the archive
|
Thanks so much for all your hard work to get this done!! |
Updated metadata for Fluxgate sensor and Centaur datalogger at the new West Melton 2 GeoMag site