Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Westmelton2 GeoMag equipment update #2025

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

TurnerDave
Copy link
Contributor

@TurnerDave TurnerDave commented Apr 15, 2024

Updated metadata for Fluxgate sensor and Centaur datalogger at the new West Melton 2 GeoMag site

  • network/stations.csv (geomag has network code = GM)
  • network/sites.csv (geomag has channel code = 50 for the fluxgate and 51 for the proton)
  • calibrations/fluxgate : a text file with Danish Met Insitute calibration results for individual fluxgate sensor and driver
  • assets/dataloggers.csv
  • assets/recorders.csv comment: N/A
  • assets/sensors.csv comment: Existing sensor redeployed
  • install/calibrations.csv comment: Existing sensor redeployed
  • install/channels.csv (check that model is there)
  • install/components.csv (check that model and response file is there)
  • install/connections.csv
  • install/dataloggers.csv
  • install/gains.csv
  • install/recorders.csv comment: N/A
  • install/sensors.csv
  • install/streams.csv
  • /files (check model is there) comment: resp/files/sensor_Danish_Meteorological_Institute_FGE.xml exists

@TurnerDave TurnerDave added the geomag Geomagnetic based work label Apr 15, 2024
@TurnerDave TurnerDave self-assigned this Apr 15, 2024
@TurnerDave TurnerDave requested review from ozym and a team as code owners April 15, 2024 05:09
Copy link
Contributor

@elidana elidana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hei @TurnerDave , this is a new site, and will require a bunch of more metadata to be added on delta before this pull request can be merged.

The complete set of files that need to include geomag metadata is:

  • network/stations.csv (geomag has network code = GM)
  • network/sites.csv (geomag has channel code = 50 for the fluxgate and 51 for the proton)
  • calibrations/fluxgate : a text file with Danish Met Insitute calibration results for individual fluxgate sensor and driver
  • assets/dataloggers.csv
  • assets/recorders.csv
  • assets/sensors.csv
  • install/calibrations.csv
  • install/channels.csv (check that model is there)
  • install/components.csv (check that model and response file is there)
  • install/connections.csv
  • install/dataloggers.csv
  • install/gains.csv
  • install/recorders.csv
  • install/sensors.csv
  • install/streams.csv
  • resp/files (check model is there)

@TurnerDave
Copy link
Contributor Author

Thanks @elidana I have no idea what I'm doing, so I really appreciate your guidance. I'll update the field you listed :)

@TurnerDave TurnerDave requested a review from elidana April 16, 2024 00:33
@TurnerDave
Copy link
Contributor Author

@elidana check-list completed and changes made where required. Thank you for your help.

@TurnerDave TurnerDave marked this pull request as draft April 16, 2024 02:08
@TurnerDave
Copy link
Contributor Author

Note that I need to confirm the correct install/gains.csv values following feedback from Mark C. Will re-submit once updated.

@TurnerDave TurnerDave marked this pull request as ready for review April 16, 2024 03:02
@TurnerDave
Copy link
Contributor Author

Correct gain values updated. PR ready for review. Thanks for your help and guidance @elidana and @ozym

Copy link
Contributor

@elidana elidana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done on wrangling this! some more comments and tweaks

A couple of general comments (in addition to the more detailed in line ones)

  • is there a calibration file for this sensor? If so, can we please add it to the calibration/fluxgates folder. This is usually a copy of the calibration PDF received by the Danish Met Institute, file name has the same serial number used here
  • In general, the station name needs to be consistent across different files. I propose to use
    West Melton Geomagnetic Observatory 2 or West Melton 2 Geomagnetic Observatory everywhere

see also other more detailed comments

network/stations.csv Outdated Show resolved Hide resolved
network/sites.csv Outdated Show resolved Hide resolved
install/connections.csv Outdated Show resolved Hide resolved
install/dataloggers.csv Outdated Show resolved Hide resolved
install/gains.csv Outdated Show resolved Hide resolved
install/sensors.csv Outdated Show resolved Hide resolved
@TurnerDave
Copy link
Contributor Author

@elidana We're getting there. All points above addressed and ready for review. Thanks for your patience :)

@elidana
Copy link
Contributor

elidana commented Apr 16, 2024

  • thanks for addressing all comments!
  • calibration file: APOLOGIES! i did not realised that the sensor was already in use in SBAM in the past. Calibration file was already available in delta (https://github.com/GeoNet/delta/blob/main/calibration/fluxgates/FGE_S0257.const.md) so can you please remove the uploaded PDF? (for calibrations, we usually reformat the PDF provided by the Danish institute, so that the info is a bit more structured). sorry for the unnecessary extra work
  • some tests are still failing, will check how to fix and comment here.
  • thanks for adding info on gains in the internal ticket!

@TurnerDave
Copy link
Contributor Author

TurnerDave commented Apr 17, 2024

@elidana I should have questioned adding the pdf, as the other sensors didn't have their calibration certs uploaded. I now have a problem that I can't delete the pdf from the pull request. The option to delete the file is greyed-out. I can delete the entire directory, but not that file inside of it. Any ideas? I don't really want to delete the pull request and start again.
image

@elidana elidana force-pushed the TurnerDave-westmelton2-update branch from c498833 to 4fabf2d Compare April 17, 2024 06:53
@elidana
Copy link
Contributor

elidana commented Apr 17, 2024

ok, I did some tweaks on this pr

  • deleted the pdf (apologies for the confusing message and for missing the info were there already)
  • moved entries to pass the tests (they need to be in alpha-numerical orders in all files)
  • squashed all commits into one

all tests are now passing

@elidana
Copy link
Contributor

elidana commented Apr 17, 2024

@CBurton90 or @gva6500 can you please review this from the RIM team perspective?

@ozym , this is a new site. I can see already miniseed data poppinp up in the archive, but would be great if you can double check that this is complete!

ozym
ozym previously approved these changes Apr 17, 2024
Copy link
Contributor

@ozym ozym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passes the tests and has the gain settings.

CBurton90
CBurton90 previously approved these changes Apr 18, 2024
Copy link
Contributor

@CBurton90 CBurton90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for your efforts here @TurnerDave

@elidana elidana dismissed stale reviews from CBurton90 and ozym via 7ec5251 April 18, 2024 04:33
@elidana elidana force-pushed the TurnerDave-westmelton2-update branch from 4fabf2d to 7ec5251 Compare April 18, 2024 04:33
@elidana
Copy link
Contributor

elidana commented Apr 18, 2024

install times updated to reflect first data in the archive

FDSN:NZ_EY2M_50_L_F_X, 2, 512, 412 samples, 1 Hz, 2024-04-09T02:29:55.000000Z (100)
FDSN:NZ_EY2M_50_L_F_X, 2, 512, 412 samples, 1 Hz, 2024-04-09T02:36:47.000000Z (100)
FDSN:NZ_EY2M_50_L_F_X, 2, 512, 412 samples, 1 Hz, 2024-04-09T02:43:39.000000Z (100)
FDSN:NZ_EY2M_50_L_F_X, 2, 512, 412 samples, 1 Hz, 2024-04-09T02:50:31.000000Z (100)
FDSN:NZ_EY2M_50_L_F_X, 2, 512, 412 samples, 1 Hz, 2024-04-09T02:57:23.000000Z (100)

@elidana elidana requested a review from ozym April 18, 2024 04:34
@elidana elidana requested a review from CBurton90 April 18, 2024 04:34
@elidana elidana merged commit 74a5f0e into main Apr 18, 2024
18 checks passed
@elidana elidana deleted the TurnerDave-westmelton2-update branch April 18, 2024 04:36
@tanjapetersen
Copy link

Thanks so much for all your hard work to get this done!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geomag Geomagnetic based work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants