Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fge bias for EY2M #2042

Merged
merged 1 commit into from
May 6, 2024
Merged

fix: update fge bias for EY2M #2042

merged 1 commit into from
May 6, 2024

Conversation

ozym
Copy link
Contributor

@ozym ozym commented May 4, 2024

Appears the offsets were in the wrong order, i.e. xyz -> zyx

Tested and the values come much closer, and the two sets at West Melton look closer in offsets as well.

Appears the offsets were in the wrong order, i.e. xyz -> zyx
@ozym ozym requested a review from a team as a code owner May 4, 2024 10:01
@ozym ozym self-assigned this May 4, 2024
@ozym ozym added the geomag Geomagnetic based work label May 4, 2024
@tanjapetersen
Copy link

Hi @ozym - the title says EYRM, but from what you mentioned before issue with the offsets is in the EY2M data??

@ozym ozym changed the title fix: update fge bias for EYRM fix: update fge bias for EY2M May 6, 2024
@ozym
Copy link
Contributor Author

ozym commented May 6, 2024

Hi @ozym - the title says EYRM, but from what you mentioned before issue with the offsets is in the EY2M data??

good catch, have updated title.

Copy link
Contributor

@elidana elidana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch @ozym !!!
did check against photos taken at time of installation and happy with that fix. Apologies if I missed that while reviewing #2025

@ozym ozym merged commit 050d584 into main May 6, 2024
18 checks passed
@ozym ozym deleted the update-ey2m branch May 6, 2024 01:29
@tanjapetersen
Copy link

nT values should be the same for EYWM and EY2M after the change
EYMvsEY2M

@elidana
Copy link
Contributor

elidana commented May 6, 2024

once metadata have been updated, the change should be "deployed to tilde" and data potentially reprocessed before that to be visible on the plots?

@ozym
Copy link
Contributor Author

ozym commented May 6, 2024

this doesn't get "deployed" to tilde.

@tanjapetersen
Copy link

I just wanted to point out a quick way to check if calibration is correct. Both instruments should record the same magnetic field

@elidana
Copy link
Contributor

elidana commented May 6, 2024

ha ha cool, all good and thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geomag Geomagnetic based work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants