-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rules creation using GeoFence batch #10537
Labels
Comments
etj
added a commit
that referenced
this issue
Jan 16, 2023
12 tasks
12 tasks
etj
added a commit
that referenced
this issue
Jan 16, 2023
etj
added a commit
that referenced
this issue
Jan 16, 2023
etj
added a commit
that referenced
this issue
Jan 16, 2023
etj
added a commit
that referenced
this issue
Jan 17, 2023
afabiani
added a commit
that referenced
this issue
Jan 23, 2023
* [Fixes #10537] Improve rules creation using GeoFence batch * - code improvements accordingly to the PR comments * - code improvements accordingly to the PR comments * - Test fixes Co-authored-by: afabiani <alessio.fabiani@geosolutionsgroup.com>
afabiani
pushed a commit
that referenced
this issue
Jan 23, 2023
…10567) * [Fixes #10537] Improve rules creation using GeoFence batch * - code improvements accordingly to the PR comments * - code improvements accordingly to the PR comments * - Test fixes Co-authored-by: afabiani <alessio.fabiani@geosolutionsgroup.com> (cherry picked from commit d101ead) Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
etj
added a commit
that referenced
this issue
Jan 25, 2023
etj
added a commit
that referenced
this issue
Jan 26, 2023
etj
added a commit
that referenced
this issue
Jan 26, 2023
etj
added a commit
that referenced
this issue
Jan 26, 2023
etj
added a commit
that referenced
this issue
Jan 26, 2023
afabiani
pushed a commit
that referenced
this issue
Jan 26, 2023
#10585) (#10588) * [Code Formatting] Revert formatting on conflicting files * [Fixes #10537] Improve rules creation using GeoFence batch - more improvements * [#10574] Align code formatting with black Co-authored-by: afabiani <alessio.fabiani@geosolutionsgroup.com> (cherry picked from commit 36f414d) Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
12 tasks
ridoo
pushed a commit
to Thuenen-GeoNode-Development/geonode
that referenced
this issue
Sep 18, 2023
…oNode#10538) (GeoNode#10567) * [Fixes GeoNode#10537] Improve rules creation using GeoFence batch * - code improvements accordingly to the PR comments * - code improvements accordingly to the PR comments * - Test fixes Co-authored-by: afabiani <alessio.fabiani@geosolutionsgroup.com> (cherry picked from commit d101ead) Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
ridoo
pushed a commit
to Thuenen-GeoNode-Development/geonode
that referenced
this issue
Sep 18, 2023
…ore imp… (GeoNode#10585) (GeoNode#10588) * [Code Formatting] Revert formatting on conflicting files * [Fixes GeoNode#10537] Improve rules creation using GeoFence batch - more improvements * [GeoNode#10574] Align code formatting with black Co-authored-by: afabiani <alessio.fabiani@geosolutionsgroup.com> (cherry picked from commit 36f414d) Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
ridoo
pushed a commit
to Thuenen-GeoNode-Development/geonode
that referenced
this issue
Feb 22, 2024
…oNode#10538) (GeoNode#10567) * [Fixes GeoNode#10537] Improve rules creation using GeoFence batch * - code improvements accordingly to the PR comments * - code improvements accordingly to the PR comments * - Test fixes Co-authored-by: afabiani <alessio.fabiani@geosolutionsgroup.com> (cherry picked from commit d101ead) Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
ridoo
pushed a commit
to Thuenen-GeoNode-Development/geonode
that referenced
this issue
Feb 22, 2024
…ore imp… (GeoNode#10585) (GeoNode#10588) * [Code Formatting] Revert formatting on conflicting files * [Fixes GeoNode#10537] Improve rules creation using GeoFence batch - more improvements * [GeoNode#10574] Align code formatting with black Co-authored-by: afabiani <alessio.fabiani@geosolutionsgroup.com> (cherry picked from commit 36f414d) Co-authored-by: Emanuele Tajariol <etj@geo-solutions.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The creation of the Rules in GeoFence should be as quick as possibile, since it may lead to excessive waiting time and, in some cases, to the failure of the logic related to guardian/geofence sync.
At the moment, in order to create a rule in GeoFence, 3 REST API calls are invoked:
(btw, the priority computation at the moment is wrong, since it reuses the last used priority)
In order to improve the performance of rule creation, we can leverage on the use of GeoFence batch;
refs:
Also, I noted that the syntax for the batch command implemented in GeoServer does not match the original (standalone) one:
https://docs.geoserver.org/latest/en/user/extensions/geofence-server/rest-batch-op.html
Of course at the moment we'll follow the syntax for the embedded GeoFence, but the API will need to be aligned on GeoServer.
Instead of issuing REST calls for creating a single rule, we can
The text was updated successfully, but these errors were encountered: