-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rules creation using GeoFence batch - WPS #10929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giohappy
reviewed
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@etj I'd prefer to decide whether use WPS subfields by inspecting the version directly from Geoserver: /geoserver/rest/about/version.json
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #10929 +/- ##
==========================================
- Coverage 62.42% 62.41% -0.01%
==========================================
Files 828 828
Lines 51526 51547 +21
Branches 6593 6598 +5
==========================================
+ Hits 32165 32175 +10
- Misses 17658 17664 +6
- Partials 1703 1708 +5 |
giohappy
reviewed
May 5, 2023
giohappy
approved these changes
May 5, 2023
ridoo
pushed a commit
to Thuenen-GeoNode-Development/geonode
that referenced
this pull request
Jun 2, 2023
* Add WPS subfield rule in GeoFence * Add WPS subfield rule in GeoFence * Add WPS subfield rule in GeoFence * Add WPS subfield rule in GeoFence * Add WPS subfield rule in GeoFence * Add WPS subfield rule in GeoFence * Add WPS subfield rule in GeoFence * Add WPS subfield rule in GeoFence -- fix parsing geoserver version --------- Co-authored-by: Giovanni Allegri <giohappy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more improvements related to #10537, adding WPS specific rules.
The WPS rules have only been implemented since geoserver 2.23.0, so there's a version check to create the proper set of rules.
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.