Missing translation tags in layer_list and layer_detail

[obersupermega]

Expected Behavior

In all languages, the name and description of the data categories should be displayed in the appropriate language.

Actual Behavior

(missing {% trans item.category__gn_description} in _resourcebase_snippet.html e.g.)

Steps to Reproduce the Problem

1. Change language, e.g. to french
2. Go to layer list or go to layers detail page

Specifications

• GeoNode version: 3.x
• Installation method: SPCGeoNode Docker
• Platform: Ubuntu
• Additional details:

[gannebamm]

I think since those Topic Categories are now part of the datamodel itself instead of pre-modelled the translation strings will vary. See e.G. http(s)://your.geonode.url/de/admin/base/topiccategory/

There you have the topic description and name as part of the database model. I am not sure how those would get translated. @t-book and @afabiani ? What is your suggestion?

[obersupermega]

That's right. But if the information is processed in _resourcebase_snippet.html you should still be able to translate the received variable as a string with "{% trans item.category__gn_description}" or a similar call.
On index.html/iso_categories.html it works:

[obersupermega]

[gannebamm]

I've just got two infos:
First: gannebamm@c7ea759#r43512134
The msgids are commented in some translation.po files, since they are no longer part of the html and therefore do not get create with the create_message django command (or get even commented out, like in the german one I've edited yesterday).
Second: The currently by fixtures inserted iso-category descriptions do sometimes differ from the msgids strings in the po files. Eg. the Oceans iso-cat must start with uppercase 'F' and end with a '.'. If these are changed in the django admin, the help text will get translated aswell. Ssee @obersupermega example above with france shortname but english description and mine:

[gannebamm]

See my draft PR: #6565

[gannebamm]

I tried to use {% trans ... } but it did not work as expected due to angular I think. Any hints are very much appreciated.
☝️ 26. Oktober 2020 10:07

[gannebamm]

@afabiani @t-book The initial data json fixture is not matching with the .po file strings. There are two options:
a) change the po file msgid for all languages,
b) change the fixture

I have not enough experience to tell which of those options is better in terms of updateability and djangoness. See the fixture changes here:
gannebamm@2819ea6

I´ve tested that locally and it does work fine for a new instance.

[afabiani]

@gannebamm the best option would be to change the fixture imho.

[gannebamm]

See my PR: #6565
Most of the issue is solved there.

[obersupermega]

Great job.But unfortunately, not all the passages are translated. Shall we reopen the issue?

[gannebamm]

Just for documentation purposes:
@obersupermega see my thoughts about that here #6565 (comment)
In short: those are fetched from the (soon) old API and I would have to write a custom serializer for it - AFAIK. This is currently out of scope for me. Nevertheless the rest of the translations should get merged for 3.1 release.