-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #6534] Missing translation tags in layer_list and layer_detail #6565
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6565 +/- ##
=======================================
Coverage 59.34% 59.34%
=======================================
Files 188 188
Lines 21198 21198
Branches 3506 3506
=======================================
Hits 12579 12579
Misses 7521 7521
Partials 1098 1098 |
6485901
to
4cc776e
Compare
4edaa14
to
e4aa2cd
Compare
b025b3c
to
6927a65
Compare
# Conflicts: # geonode/locale/de/LC_MESSAGES/django.po # requirements.txt
…. Defuzzied some strings
I merged current master in my branch and updated the (german) translations again. I am still stuck with getting translated iso-categories from tastypie. Therefore the search side-bar categories are not yet translated (see #6534 second picture, left-hand side). The other missing strings do now work (tested for the german translation). @afabiani I would wait for the tests and then merge this. I changed the fixtures as discussed. The other issue is most likely soon obsolete due to the new v2 api? @t-book told me I could write a serializer for tastypi to get the strings translated, but that is to much work, for a (for me at least) minor issue. What do you think? |
@gannebamm before merging this one two things:
|
No, it is not. I am sorry. Some local commit must have been accidentally pushed to my branch on GitHub.
There are no new msgids so I think this is not needed. Nonetheless, I have used the commands but do not see any local changes after
But I think those can be ignored |
…#6565) * updated geo limit texts and cart [#6131] * iso-categories translation msgid fix * layer detail trans tags [FIXES #6534] * adds layer list objects and layer detail iso category translations. * Revert " - Add django-grappelli==2.14.2 admin interface" This reverts commit c9f594c * get Iso categories po texts back and updated german trans for geoapps. Defuzzied some strings * added compiled .mo file * - Revert "grappelli" removal Co-authored-by: Alessio Fabiani <alessio.fabiani@geo-solutions.it> (cherry picked from commit 437914c)
Iso-Category texts will not get translated throughout the application. This PR fixes the fixtures (done) and will add
{% trans %}
tags were needed (not done yet)Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.