-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2.0 release #73
Merged
Merged
1.2.0 release #73
Changes from all commits
Commits
Show all changes
192 commits
Select commit
Hold shift + click to select a range
aa823d7
v1.1.2.dev0 version bump [skip ci]
MuellerSeb e6b7adc
CI: py35-py38 on Travis for all systems
MuellerSeb f2c4201
CI: drop Appveyor
MuellerSeb ec4f890
tests: delete __init__.py in test as best practice
MuellerSeb 74207e6
Only support Python >= 3.5 (#43)
LSchueler 3f81bbf
add infos for zenodo
MuellerSeb 98ba03c
remove appveyor badge [skip ci]
MuellerSeb 85da6a9
Update readmes with conda install instructions
LSchueler 576700d
README: add conda badge
MuellerSeb 9254ab8
DOC: update the install instructions for pip and openmp
MuellerSeb ace7e2c
CI: coverage test with openmp
MuellerSeb a188a28
Remove some Py27 legacy code from the unittests
LSchueler cc89945
Delete detailed install. instructions from readme
LSchueler bf702a4
CovModel: check optional arguments and warn if unknown (#46)
MuellerSeb 312f3b0
CI: no deploy for pull requests (#49)
MuellerSeb 9a236ac
Hankel update (#48)
MuellerSeb dc9f325
Use global compiler directives in cython, drop py2
LSchueler b73162c
Add some const-correctness to cython code
LSchueler b9b7f5a
Refactor variogram cython code
LSchueler 247badd
Add Cressie type variogram estimator as a choice
LSchueler c846ddc
Remove f-string for Py35 compatibility
LSchueler f92fe0f
Update variogram docs
LSchueler f5a5449
Grand Unification of struct. variogram estimators
LSchueler e6095f7
Fix race conditions in struct variogram estimation
LSchueler c76a6bd
Update changelog
LSchueler 4bde6a0
Update doc
LSchueler a7b0b39
Fix typo in docstring
LSchueler d602a55
Sphinx gallery (#63)
banesullivan 591afc1
CovModel: Doc update; changed calculation of anisotropy in 3D
MuellerSeb 2a0b027
CI: fix coverage version
MuellerSeb df2c0da
variogram: blackened
MuellerSeb 7cd1d6a
Field-base: add _update_model dummy method
MuellerSeb f6c95be
Field: add pre_pos method for position conversion
MuellerSeb 086cfb0
Tests: Bugfix in TestSRF
MuellerSeb 39b03ac
Field: bugfix for pos
MuellerSeb c2332c8
Tools: doc update
MuellerSeb f326830
Tests: fix wrongly set model attributes
MuellerSeb 78f7d9e
Tests: blackened
MuellerSeb f068b4d
Tests: more wrong attr warning fixes
MuellerSeb 4cfbe17
Field: refactoring
MuellerSeb 56e2181
Field: add switch in pre_pos to make mesh unstruct
MuellerSeb f19a711
Field: check for scalar field when using conditions
MuellerSeb c5586a2
Krige: add a base class for kriging
MuellerSeb 3c6dbdd
Krige: add generator for drift functions
MuellerSeb 779729f
Krige: make pos2 in get_dists optional
MuellerSeb ddb14d5
Krige: adopt simple kriging to new base class
MuellerSeb 6ddc5a9
Field: remove update_model routine
MuellerSeb 05564a4
Krige: update Simple kriging
MuellerSeb b163b72
Krige: use unstructured pos in the RHS of the kriging eq
MuellerSeb e84df75
Tests: adopt new interface of simple kriging
MuellerSeb a436f37
Krige: add unrotated isoropic cond_pos as attribute
MuellerSeb 317dcf1
Field: saver setting of mean
MuellerSeb 691bbb2
Krige: refactor base
MuellerSeb 9d914fa
Krige: bugfix in update_model; first calc. krige_pos
MuellerSeb 9cff6db
Krige: bugfix in Simple kriging: fix get_krige_vecs
MuellerSeb 36c99b7
Krige: remove linear term in drift functions; use unbiased condition …
MuellerSeb e4d0685
Krige: add drift_function handling to base; bugfixes; refactoring
MuellerSeb 53b2021
Krige: adopt Ordinary; add Universal and ExtDrift
MuellerSeb 839207c
Krige: calculate mean in Ordinary kriging
MuellerSeb 657d161
Krige: bugfixing Universal and ExtDrift
MuellerSeb 47e0bbb
Examples: add examples for universal and ext-drift kriging
MuellerSeb 32b0502
CovModel: only do rotation if model is anisotropic
MuellerSeb 2f14903
Krige: add method descriptions
MuellerSeb a36e417
Field: check for anisotropy before making isotrop
MuellerSeb 252101f
Krige: tools doc update
MuellerSeb 90dfe99
Krige: add eval_func to tools
MuellerSeb 944521c
Krige: better handling of drift in base
MuellerSeb 321d5fe
Krige: add detrended kriging; slightly refactor kriging methods
MuellerSeb 0aa963f
Examples: add detrended example; update kriging examples
MuellerSeb 73a30ef
Krige: detrend bugfix
MuellerSeb 7c49820
CovModel: simplify ln_spectral_rad_pdf; update covmodel examples
MuellerSeb d947bc7
CovModel: minimal refactor; doc update
MuellerSeb bc519cd
CovModel: update TPL models
MuellerSeb 00ab0b2
TPLModels: add spectral dens formulas for TPL models to tools
MuellerSeb 52a535f
TPLModel: use analytical formula for spectral densities
MuellerSeb a5a814e
Krige: doc update
MuellerSeb 403049f
Krige base: rename update_model to update
MuellerSeb 72901d6
Krige: add DetrendedOrdinary; Doc update
MuellerSeb 0b4ce56
Examples: add detrended ordinary kriging example
MuellerSeb 9f530dd
Krige: provide interface for a trend function to all kriging routines…
MuellerSeb 2259d44
Krige: avoid unnecessary function call
MuellerSeb f360048
Examples: apply new sphinx-gallery style to kriging
MuellerSeb eb5bd2e
update controle files
MuellerSeb 0f8d4b9
Krige: remove debug print out
MuellerSeb 860d598
Examples: revise numbering
MuellerSeb 873dce2
Field tools: add counterparts for rotation and scaling
MuellerSeb 6040d93
Krige: bugfix in eval_func
MuellerSeb 553cc3a
Krige: clarifying comment in base class
MuellerSeb affed73
Field tools: change rotation order in rotate_mesh in 3D
MuellerSeb 54f9238
Krige: bugfix for rotation and anisotropy for universal kriging
MuellerSeb f482117
Krige: wrong pos tuple used for trend, dont use isotropic rotated ones
MuellerSeb fadd5cc
Tests: add test for universal kriging
MuellerSeb 6f9d4f9
Krige: rework drift_func factory
MuellerSeb 5d7c760
Krige: better check single external drift
MuellerSeb 4543a3e
Tests: add tests for external drift and detrended kriging
MuellerSeb ecf4c2b
Krige: doc update; allow integer as drift in universal kriging
MuellerSeb 9d13787
Tests: to few data points for quad-drift checking->skip
MuellerSeb d87ccdf
Tests: test callable drift input
MuellerSeb ad603b9
Tests: test detrended ordinary kriging
MuellerSeb 58a05de
Examples: update Herten example
MuellerSeb 1248835
DOC Gallery: suppress expression print out
MuellerSeb 1a526bf
Examples: update 00_misc
MuellerSeb 04b0b0e
Examples: update 01_random_field
MuellerSeb cedbf6a
Examples: update 03_variogram
MuellerSeb c3fb775
Examples: update 04_vector_field
MuellerSeb 340d280
Examples: update 05_kriging
MuellerSeb b9b2828
Examples: update 06_conditioned_fields
MuellerSeb 5b28e19
Examples: update 07_transformations
MuellerSeb 8a48115
Examples: typo fix
MuellerSeb 6f488f0
Examples: update 02_cov_model
MuellerSeb bf9c34a
Examples: add Gallery captions
MuellerSeb 992c02e
CovModel: bugfix in spatial plotting routines
MuellerSeb 7b4cc2f
Init: add missing imports; remove deprecation warnings
MuellerSeb 2205fcf
Examples: reorder 02_cov_model
MuellerSeb 2efea69
CovModel: always add the cor method
MuellerSeb 8b1a621
DOC: rename cor to rho
MuellerSeb bf25da6
Examples: rename cor to rho
MuellerSeb 39beb5b
CovModel: typo
MuellerSeb 5197468
Tools: add to_vtk routines to doc
MuellerSeb 1ce881f
DOC: update doc stings for sphinx autosummary
MuellerSeb 688fdde
Examples: edit cross references to be unique
MuellerSeb 7937105
DOC: add temple for autosummary for classes
MuellerSeb 0651485
Ignore: generated docs
MuellerSeb 9f32b99
Ignore fix
MuellerSeb 8303b6a
Examples: fix some references
MuellerSeb c3abda5
Examples: update scale comparison
MuellerSeb 6d473f2
Examples: links to CovModel routines in description
MuellerSeb 795016c
Update readme's according to the new examples
LSchueler bcd5ee9
Remove unnecessary imports from readme's
LSchueler c8eca7d
Examples: fix srf merge example
MuellerSeb bdc42e8
Tests: add test for cor definition
MuellerSeb fabd89e
Tests: blackened
MuellerSeb daa8362
Merge branch 'develop' into krige_update
MuellerSeb 06a6459
Examples: add missing Doc-string in UK example
MuellerSeb 908a2fb
fix strange rtd error with missing mode-kw in np.pad
MuellerSeb c805121
Krige: doc update krige_mat
MuellerSeb 4c7ba81
Doc: updates
MuellerSeb 80fc4f8
Doc: CovModel path updates
MuellerSeb 546c010
Krige: restructure classes; make intern functions private to keep doc…
MuellerSeb 538ba5b
Examples: fix broken links
MuellerSeb abecf47
Examples: update kriging readme
MuellerSeb e3f49ed
Fix some typos
LSchueler a8a6a44
Fix typo in docstring
LSchueler 89db777
Krige-base: saver setting of drift
MuellerSeb de1db21
use axis_lens everywhere; chunk_size doc
MuellerSeb 4028d25
Docs: add logos
MuellerSeb 5d843df
Krige: Deprecation warning handling: collections.abc for py39 compat
MuellerSeb a6fa7ed
krige: finalize branch; Changelog; version bump
MuellerSeb c7e526d
Merge pull request #67 from GeoStat-Framework/krige_update
MuellerSeb 7001713
Blacken
LSchueler 2062538
Add discrete transform function
LSchueler b3dc870
Add unittest to discrete transform function
LSchueler 56e652b
Update examples
LSchueler 4ced50c
Add item to changelog
LSchueler a4446c1
Remove unnecessary input check and add an example
LSchueler 96e5ce1
Add possibility to add more threshold calculations
LSchueler 0f24aad
transform: Add equal thresholds option to discrete; bugfix in discret…
MuellerSeb 2f08ebf
examples: add equal thresholds example for discrete transform
MuellerSeb ac8fe5c
tests: test equal thresholds in discrete transform
MuellerSeb 66ea6a8
Update docstring
LSchueler f622e42
Examples: bugfix in 02_discrete.py
MuellerSeb da528a3
Handle versioning with setuptools_scm
MuellerSeb cd6fc29
Don't set a version by default; no version provided if not installed
MuellerSeb 04f0b01
travis maybe didn't see the present tags because of the default clone…
MuellerSeb 982df7b
update travis
MuellerSeb dd3aee5
travis: remove unnecessary sudo requirement
MuellerSeb a8d039c
doc: use git to install dev-version with pip
MuellerSeb 48573c8
Merge pull request #72 from GeoStat-Framework/automated_versioning
MuellerSeb 9b47daa
Travis: update versions of cibuildwheel to 1.3 and python(win) to 3.8.2
MuellerSeb ed55c8a
setup.cfg: no need for universal wheels
MuellerSeb 04349dd
setup: All req. in external files; setup.py cleanup
MuellerSeb a2b47d4
Travis: force to use python3
MuellerSeb 2982ad2
Setup: Better handling of req.
MuellerSeb 75d7de0
Setup: update setup req.
MuellerSeb 1c5ef3b
Setup: add extra options for test and doc
MuellerSeb 7aab462
Travis: Cleanup windows builds
MuellerSeb 05d8e03
Setup: typo fix
MuellerSeb 9ffe7c2
DOC: add pyvista to req.
MuellerSeb a62df4f
Travis: Use py3.8.0 for win like suggested by cibuildwheel
MuellerSeb cf4bc66
CovModel: adopt to new version of hankel (1.0.2)
MuellerSeb 8579938
Travis: Update test command for cibuildwheel
MuellerSeb adb924f
DOC: update req., update citing; update badges; move TPL example
MuellerSeb 9c9bd07
DOC: update year in copyright
MuellerSeb 2a3ddc7
Changlog: prepare v1.2.0
MuellerSeb 4e3484d
Changelog: Add work of Bane Sullivan
MuellerSeb 0d1126a
README: always point to the stable doc
MuellerSeb 3ab505b
DOC: update references
MuellerSeb 040f17a
DOC: remove year (already present)
MuellerSeb c811724
TRAVIS: allow present releases on PyPI, so we can handle deploy crash…
MuellerSeb 247ad4c
Zenodo: json was not valid (https://codebeautify.org/jsonvalidator)
MuellerSeb 7b83103
Merge branch 'master' into 1.2.0_release
MuellerSeb 6d9ba59
Remove sphinx output from repo and ignore it
LSchueler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,137 +1,100 @@ | ||
language: python | ||
python: 3.8 | ||
|
||
matrix: | ||
include: | ||
- name: "Linux py27" | ||
sudo: required | ||
language: python | ||
python: 2.7 | ||
services: docker | ||
env: | ||
- PIP=pip | ||
- CIBW_BUILD="cp27-*" | ||
- COVER="off" | ||
# setuptools-scm needs all tags in order to obtain a proper version | ||
git: | ||
depth: false | ||
|
||
env: | ||
global: | ||
- TWINE_USERNAME=geostatframework | ||
- CIBW_BEFORE_BUILD="pip install numpy==1.17.3 cython==0.29.14 setuptools" | ||
- CIBW_TEST_REQUIRES=pytest | ||
- CIBW_TEST_COMMAND="pytest -v {project}/tests" | ||
|
||
- name: "Linux py34" | ||
sudo: required | ||
language: python | ||
python: 3.4 | ||
before_install: | ||
- | | ||
if [[ "$TRAVIS_OS_NAME" = windows ]]; then | ||
choco install python --version 3.8.0 | ||
export PATH="/c/Python38:/c/Python38/Scripts:$PATH" | ||
# make sure it's on PATH as 'python3' | ||
ln -s /c/Python38/python.exe /c/Python38/python3.exe | ||
fi | ||
|
||
script: | ||
- python3 -m pip install cibuildwheel==1.3.0 | ||
- python3 -m cibuildwheel --output-dir dist | ||
|
||
after_success: | ||
- | | ||
if [[ $TRAVIS_PULL_REQUEST == 'false' ]]; then | ||
python3 -m pip install twine | ||
python3 -m twine upload --verbose --skip-existing --repository-url https://test.pypi.org/legacy/ dist/* | ||
if [[ $TRAVIS_TAG ]]; then python3 -m twine upload --verbose --skip-existing dist/*; fi | ||
fi | ||
|
||
notifications: | ||
email: | ||
recipients: | ||
- info@geostat-framework.org | ||
|
||
jobs: | ||
include: | ||
- name: "sdist and coverage" | ||
services: docker | ||
env: | ||
- PIP=pip | ||
- CIBW_BUILD="cp34-*" | ||
- COVER="off" | ||
env: OMP_NUM_THREADS=4 | ||
script: | ||
- python3 -m pip install -U setuptools pytest-cov coveralls | ||
- python3 -m pip install -U numpy==1.17.3 cython==0.29.14 | ||
- python3 -m pip install -r requirements.txt | ||
- python3 setup.py sdist -d dist | ||
- python3 setup.py --openmp build_ext --inplace | ||
- python3 -m pytest --cov gstools --cov-report term-missing -v tests/ | ||
- python3 -m coveralls | ||
|
||
- name: "Linux py35" | ||
sudo: required | ||
language: python | ||
python: 3.5 | ||
services: docker | ||
env: | ||
- PIP=pip | ||
- CIBW_BUILD="cp35-*" | ||
- COVER="off" | ||
|
||
# py36 for coverage and sdist | ||
env: CIBW_BUILD="cp35-*" | ||
- name: "Linux py36" | ||
sudo: required | ||
language: python | ||
python: 3.6 | ||
services: docker | ||
env: | ||
- PIP=pip | ||
- CIBW_BUILD="cp36-*" | ||
- COVER="on" | ||
|
||
# https://github.com/travis-ci/travis-ci/issues/9815 | ||
env: CIBW_BUILD="cp36-*" | ||
- name: "Linux py37" | ||
sudo: required | ||
language: python | ||
python: 3.7 | ||
dist: xenial | ||
services: docker | ||
env: | ||
- PIP=pip | ||
- CIBW_BUILD="cp37-*" | ||
- COVER="off" | ||
|
||
- name: "MacOS py27" | ||
os: osx | ||
language: generic | ||
env: | ||
- PIP=pip2 | ||
- CIBW_BUILD="cp27-*" | ||
- COVER="off" | ||
|
||
- name: "MacOS py34" | ||
os: osx | ||
language: generic | ||
env: | ||
- PIP=pip2 | ||
- CIBW_BUILD="cp34-*" | ||
- COVER="off" | ||
env: CIBW_BUILD="cp37-*" | ||
- name: "Linux py38" | ||
services: docker | ||
env: CIBW_BUILD="cp38-*" | ||
|
||
- name: "MacOS py35" | ||
os: osx | ||
language: generic | ||
env: | ||
- PIP=pip2 | ||
- CIBW_BUILD="cp35-*" | ||
- COVER="off" | ||
|
||
language: shell | ||
env: CIBW_BUILD="cp35-*" | ||
- name: "MacOS py36" | ||
os: osx | ||
language: generic | ||
env: | ||
- PIP=pip2 | ||
- CIBW_BUILD="cp36-*" | ||
- COVER="off" | ||
|
||
language: shell | ||
env: CIBW_BUILD="cp36-*" | ||
- name: "MacOS py37" | ||
os: osx | ||
language: generic | ||
env: | ||
- PIP=pip2 | ||
- CIBW_BUILD="cp37-*" | ||
- COVER="off" | ||
|
||
env: | ||
global: | ||
- TWINE_USERNAME=geostatframework | ||
- CIBW_BEFORE_BUILD="pip install numpy==1.14.5 cython==0.28.3" | ||
- CIBW_TEST_REQUIRES=pytest-cov | ||
# inplace cython build and test run | ||
- CIBW_TEST_COMMAND="cd {project} && python setup.py build_ext --inplace && py.test --cov gstools --cov-report term-missing -v {project}/tests" | ||
|
||
script: | ||
# create wheels | ||
- $PIP install cibuildwheel==0.11.1 | ||
- cibuildwheel --output-dir wheelhouse | ||
# create source dist for pypi and create coverage (only once for linux py3.6) | ||
- | | ||
if [[ $COVER == "on" ]]; then | ||
rm -rf dist | ||
python -m pip install -U numpy==1.14.5 cython==0.28.3 setuptools | ||
python -m pip install pytest-cov coveralls | ||
python -m pip install -r docs/requirements.txt | ||
python setup.py sdist | ||
python setup.py build_ext --inplace | ||
python -m pytest --cov gstools --cov-report term-missing -v tests/ | ||
python -m coveralls | ||
fi | ||
|
||
after_success: | ||
# pypi upload ("test" allways and "official" on TAG) | ||
- python -m pip install twine | ||
- python -m twine upload --verbose --skip-existing --repository-url https://test.pypi.org/legacy/ wheelhouse/*.whl | ||
- python -m twine upload --verbose --skip-existing --repository-url https://test.pypi.org/legacy/ dist/*.tar.gz | ||
- | | ||
if [[ $TRAVIS_TAG ]]; then | ||
python -m twine upload --verbose --skip-existing wheelhouse/*.whl | ||
python -m twine upload --verbose --skip-existing dist/*.tar.gz | ||
fi | ||
language: shell | ||
env: CIBW_BUILD="cp37-*" | ||
- name: "MacOS py38" | ||
os: osx | ||
language: shell | ||
env: CIBW_BUILD="cp38-*" | ||
|
||
notifications: | ||
email: | ||
recipients: | ||
- info@geostat-framework.org | ||
- name: "Win py35" | ||
os: windows | ||
language: shell | ||
env: CIBW_BUILD="cp35-*" | ||
- name: "Win py36" | ||
os: windows | ||
language: shell | ||
env: CIBW_BUILD="cp36-*" | ||
- name: "Win py37" | ||
os: windows | ||
language: shell | ||
env: CIBW_BUILD="cp37-*" | ||
- name: "Win py38" | ||
os: windows | ||
language: shell | ||
env: CIBW_BUILD="cp38-*" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
{ | ||
"license": "LGPL-3.0+", | ||
"contributors": [ | ||
{ | ||
"type": "Other", | ||
"name": "Bane Sullivan" | ||
}, | ||
{ | ||
"orcid": "0000-0002-2547-8102", | ||
"affiliation": "Helmholtz Centre for Environmental Research - UFZ", | ||
"type": "ResearchGroup", | ||
"name": "Falk He\u00dfe" | ||
}, | ||
{ | ||
"orcid": "0000-0002-8783-6198", | ||
"affiliation": "Hydrogeology Group, Department of Earth Science, Utrecht University, Netherlands", | ||
"type": "ResearchGroup", | ||
"name": "Alraune Zech" | ||
}, | ||
{ | ||
"orcid": "0000-0002-7798-7080", | ||
"affiliation": "Helmholtz Centre for Environmental Research - UFZ", | ||
"type": "Supervisor", | ||
"name": "Sabine Attinger" | ||
} | ||
], | ||
"language": "eng", | ||
"keywords": [ | ||
"geostatistics", | ||
"kriging", | ||
"random fields", | ||
"covariance models", | ||
"variogram", | ||
"Python", | ||
"GeoStat-Framework" | ||
], | ||
"creators": [ | ||
{ | ||
"orcid": "0000-0001-9060-4008", | ||
"affiliation": "Helmholtz Centre for Environmental Research - UFZ", | ||
"name": "Sebastian M\u00fcller" | ||
}, | ||
{ | ||
"orcid": "0000-0001-9362-1372", | ||
"affiliation": "Helmholtz Centre for Environmental Research - UFZ", | ||
"name": "Lennart Sch\u00fcler" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, you've thought of it all!