-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.2.0 release #73
Merged
Merged
1.2.0 release #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add hard Python version requirements to package * Dropped support for Py27 in setup.py * Remove __future__ 3.0 imports, the future is now * Drop Py27 and Py34 support in travis * Update changelog * Drop Py27 super * Drop Py27 'new style classes' * Remove Py27 tempfile hack from setup.py * remove six as dependency
* CovModel: better handling of single hankel kw updates * CovModel: N=200 as default for hankel transform
In cython, const's can't be used for local variables, only for function interfaces.
The estimator function and the normalization of the variogram are now being calculated in a separate function. Function pointers are used for the flexibility of choosing different estimator functions.
The function pointers in cython seem to be a bit limited, therefore I wrote 2 separate functions choosing the estimator func. and the norm. func.
In the cython code, merged the 1d-, 2d-, and 3d-versions of the structured variogram estimators into the 3d version, with a tiny little bit of preparation code in the python wrappers. Switched off the OpenMP loop for the moment, as it always results in errors for the 1d case and sometimes causes problems for higher dimensions. Super strange!
I learnt a lot about OpenMP. It seems very difficult, to adequately parallelise the structured variogram estimator in Cython. Its OpenMP support is simply to good enough. I parallelised the inner loop. It's better than nothing. The function could be implemented in pure C, C++ or maybe Rust.
* [temp] make sphinx gallery [temp] tutorial 1 migrate rename tutorial 1 files [temp] migrate tutorial 2 rename migrate all tutorials Reorganize examples Fix references Remove old doc example * Fix typos * move intro to misc * finish moving misc * Ignore MPL agg warnings * Swap order of tutorial 3 * More gitignores * CONTRIBUTING: add a hint for adding examples * Examples: typo fix Co-authored-by: Sebastian Müller <mueller.seb@posteo.de>
CI was skipped since the server is quite busy at the moment and the release candidates succeeded. |
LSchueler
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it!
|
||
## Do you want to enhance GSTools or fix something? | ||
|
||
- Fork the repo on [GitHub](https://github.com/GeoStat-Framework/GSTools) from the [develop branch](https://github.com/GeoStat-Framework/GSTools/tree/develop). | ||
- Add yourself to AUTHORS.md (if you want to). | ||
- We use the black code format, please use the script `black --line-length 79 gstools/` after you have written your code. | ||
- Add some tests if possible. | ||
- Add an example showing your new feature in one of the examples sub-folders if possible. | ||
Follow this [Sphinx-Gallary guide](https://sphinx-gallery.github.io/stable/syntax.html#embed-rst-in-your-example-python-files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, you've thought of it all!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Release of v1.2.0
[1.2.0] - Volatile Violet - 2020-03-20
Enhancements
is_isotropic
to CovModel Krige, Field and Covmodel update #67Changes
Bugfixes