🐛 Add migration generation distance to source #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
LePetitTim
force-pushed
the
bug_add_migration_generation_distancetosource
branch
from
89ccc43
to
c212390
Compare
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 156 156
Lines 5254 5254
=======================================
Hits 5180 5180
Misses 74 74 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
submarcos
reviewed
Jul 18, 2023
| for instance in model.objects.all(): | ||
| if instance._meta.model_name in ['morphology', 'status']: | ||
| stream = annotate_distance_to_source(Stream.objects.all(), instance).get( | ||
| pk=instance.topology.stream.pk) |
There was a problem hiding this comment.
Suggested change
| pk=instance.topology.stream.pk) | |
| pk=instance.topology.stream_id) |
| defaults={"distance": stream.locate.m} | ||
| ) | ||
| else: | ||
| qs = Stream.objects.none() |
There was a problem hiding this comment.
Suggested change
| qs = Stream.objects.none() |
| else: | ||
| qs = Stream.objects.none() | ||
| if not instance.geom: | ||
| return qs |
There was a problem hiding this comment.
Suggested change
| return qs | |
| return Stream.objects.none() |
LePetitTim
force-pushed
the
bug_add_migration_generation_distancetosource
branch
from
c212390
to
f585203
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.