Avoid accessing destroyed contexts in loop #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dispatch globally can cause certain events to close a view with bound context. This causes the destruction of the bound context. If this context has not yet been reached by the _.each loop that triggers the event on all contexts, an attempt will later be made to execute "context.vent.trigger" on a destroyed view and all further processing will abort on a "trying to access vent of undefined" error for that view.
|
In this case, the build is failing due to our militant code coverage requirements: Would it be possible to add a test which hits the new lines you added, and verifies the new condition? |
to ensure that when contexts are all processed in sequence to trigger the event on each one, the destruction of a yet unprocessed context does not cause the program to attempt to trigger the event on it (as it no longer exists...) when the loop reaches it
geekdave
added a commit
that referenced
this pull request
Sep 1, 2014
Avoid accessing destroyed contexts in loop
|
You're rockin' these PRs, @mmikeyy ! Thanks for finding and fixing these edge cases! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dispatch globally can cause certain events to close a view with bound context. This causes the destruction of the bound context. If this context has not yet been reached by the _.each loop that triggers the event on all contexts, an attempt will later be made to execute "context.vent.trigger" on a destroyed view and all further processing will abort on a "trying to access vent of undefined" error for that view.