Remove special config for file_public_base_url #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
dafeder
changed the title
janette
force-pushed
the
whither-file-public-base-url
branch
from
2280d84 to
a84877c
Compare
|
Tested against an existing build, removed the file_public_base_url config from settings.php, ran imports on existing datasets and dkan:sample-content:create. Everything works as expected. |
janette
approved these changes
Jan 10, 2025
janette
reviewed
Jan 10, 2025
| @@ -69,7 +69,6 @@ project_files: | |||
| - commands/web/project-test-phpunit | |||
| - misc/docker-compose.cypress.yaml | |||
| - misc/phpunit.xml | |||
| - misc/settings.dkan.php | |||
| - misc/settings.dkan-snippet.php.txt | |||
There was a problem hiding this comment.
I think we can remove the snippet file too right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports builds for GetDKAN/dkan#4276
Helps fix GetDKAN/dkan#4205
After this change, the DDEV addon does not supply
settings.dkan.php, which configuresfile_public_base_url, because it's unnecessary.Do not merge this change until we have determined that GetDKAN/dkan#4276 proves we don't need this configuration.