Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special config for file_public_base_url #52

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove special config for file_public_base_url #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b63e1d4
does not add config with public base url
paul-m Sep 5, 2024
14f858a
missed one
paul-m Sep 5, 2024
a84877c
finalize the changes
paul-m Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion commands/host/dkan-init
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ ddev composer install
# Adjust settings for our special case.
# TODO: Change this after DDev 1.19.6 is released and we can merge hooks.
cat .ddev/misc/settings.dkan-snippet.php.txt >> $DDEV_DOCROOT/sites/default/settings.php
cp .ddev/misc/settings.dkan.php $DDEV_DOCROOT/sites/default/settings.dkan.php

# TODO: Should this be in recommended-project as scaffold?
# or... in dkan module itself?
Expand Down
1 change: 0 additions & 1 deletion install.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ project_files:
- commands/web/project-test-phpunit
- misc/docker-compose.cypress.yaml
- misc/phpunit.xml
- misc/settings.dkan.php
- misc/settings.dkan-snippet.php.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the snippet file too right?

- misc/testUsers.json
- php/dkan-php.ini
Expand Down
12 changes: 0 additions & 12 deletions misc/settings.dkan.php
View file
Open in desktop

This file was deleted.

Loading