Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Deprecate DkanSqlEndpointSettingsForm #4300

Closed
2 tasks
paul-m opened this issue Oct 2, 2024 · 0 comments · Fixed by #4304
Closed
2 tasks

Remove/Deprecate DkanSqlEndpointSettingsForm #4300

paul-m opened this issue Oct 2, 2024 · 0 comments · Fixed by #4304
Assignees
Labels

Comments

@paul-m
Copy link
Contributor

paul-m commented Oct 2, 2024

Current Behavior

The form class Drupal\datastore\SqlEndpoint\Form\DkanSqlEndpointSettingsForm has this docblock:

/**
 * Settings form for the SQL endpoint.
 *
 * NO LONGER USED; TO BE REMOVED.
 *
 * @package Drupal\sql_endpoint\Form
 * @todo Remove
 */
class DkanSqlEndpointSettingsForm extends ConfigFormBase {

This is related to PR #3693

Expected Behavior

Investigate whether this class is needed, or needs a more formalized @deprecated type deprecation.

Remove this class as needed.

Steps To Reproduce

  • Notes regarding this deprecation/removal are added to this issue.
  • Automated tests pass.

Relevant log output (optional)

No response

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants