-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove max from row limit setting, combine forms #3693
Conversation
@dafeder I get an error on the docs page
|
Also am allowed to set the limit to anything on the |
It should fail validation if the limit in the query is higher than the max setting |
Ok I'll look into this. |
@janette I wasn't able to replicate the error you observed on my local environment with a Vanilla DKAN instance. Also I was able to successfully complete the QA Instructions. |
@dafeder @clayliddell yes, after a fresh build everything is working as expected. |
This PR consolidates the two datastore settings forms into one, and removes the hard limit imposed by the form on the row count.
QA Steps