Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui, localization): remove redundant platform configuration #2055

Closed
wants to merge 3 commits into from

Conversation

pcj
Copy link

@pcj pcj commented Dec 3, 2024

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Package stream_chat_flutter:windows references stream_chat_flutter:windows as the default plugin, but it does not provide an inline implementation.
Ask the maintainers of stream_chat_flutter to either avoid referencing a default implementation via `platforms: windows: default_package: stream_chat_flutter` or add an inline implementation to stream_chat_flutter via `platforms: windows:` `pluginClass` or `dartPluginClass`.
Package stream_chat_flutter:android references stream_chat_flutter:android as the default plugin, but it does not provide an inline implementation.
Ask the maintainers of stream_chat_flutter to either avoid referencing a default implementation via `platforms: android: default_package: stream_chat_flutter` or add an inline implementation to stream_chat_flutter via `platforms: android:` `pluginClass` or `dartPluginClass`.
Package stream_chat_flutter:ios references stream_chat_flutter:ios as the default plugin, but it does not provide an inline implementation.
Ask the maintainers of stream_chat_flutter to either avoid referencing a default implementation via `platforms: ios: default_package: stream_chat_flutter` or add an inline implementation to stream_chat_flutter via `platforms: ios:` `pluginClass` or `dartPluginClass`.
Package stream_chat_flutter:linux references stream_chat_flutter:linux as the default plugin, but it does not provide an inline implementation.
Ask the maintainers of stream_chat_flutter to either avoid referencing a default implementation via `platforms: linux: default_package: stream_chat_flutter` or add an inline implementation to stream_chat_flutter via `platforms: linux:` `pluginClass` or `dartPluginClass`.
Package stream_chat_flutter:macos references stream_chat_flutter:macos as the default plugin, but it does not provide an inline implementation.
Ask the maintainers of stream_chat_flutter to either avoid referencing a default implementation via `platforms: macos: default_package: stream_chat_flutter` or add an inline implementation to stream_chat_flutter via `platforms: macos:` `pluginClass` or `dartPluginClass`.
Package stream_chat_flutter:windows references stream_chat_flutter:windows as the default plugin, but it does not provide an inline implementation.

Similar to:

@pcj
Copy link
Author

pcj commented Dec 3, 2024

Can confirm this fixes the warnings on my private repo. I looked through other pubspec.yaml files in the repo and also included stream_chat_localizations.

@pcj pcj changed the title refactor(pubspec): remove redundant platform configuration fix(ui, llc): remove redundant platform configuration Dec 3, 2024
@pcj pcj changed the title fix(ui, llc): remove redundant platform configuration fix(ui, localization): remove redundant platform configuration Dec 3, 2024
@github-actions github-actions bot added the Stale label Dec 23, 2024
@xsahil03x
Copy link
Member

Closing in favor of #2068

@xsahil03x xsahil03x closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants