-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repo): bump min flutter version to 3.24.5 #2068
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2068 +/- ##
==========================================
- Coverage 61.04% 61.03% -0.01%
==========================================
Files 336 336
Lines 20152 20152
==========================================
- Hits 12301 12299 -2
- Misses 7851 7853 +2 ☔ View full report in Codecov by Sentry. |
c38e909
to
e9f1972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request includes several significant changes to improve the workflows, update dependencies, and enhance the codebase. The most important changes include the introduction of a new Pana workflow, updates to Flutter and Dart versions, and various dependency management improvements.
Workflow Improvements:
.github/actions/pana/action.yml
to verify the Pana score, including steps for installing Flutter and Pana, and verifying the score..github/workflows/pana.yml
to use the new Pana action for verifying Pana scores across multiple packages.Dependency Management:
.github/actions/pana/chore__temporarily_override_dep_to_local.patch
to temporarily override dependencies to local paths for testing purposes.melos.yaml
to include environment configurations and dependency versions, ensuring consistent dependency management across the project. [1] [2]Version Updates:
3.24.5
in multiple workflow files to ensure compatibility with the latest stable release. [1] [2]3.5.4
and minimum Flutter version to3.24.5
in variouspubspec.yaml
andCHANGELOG.md
files to reflect the latest requirements. [1] [2] [3] [4] [5]Code Enhancements:
UserBlockResponse
class inpackages/stream_chat/lib/src/core/api/responses.dart
to prevent JSON serialization fortoJson
method, improving performance._IsSameMessageAs
matcher inpackages/stream_chat/test/src/matchers.dart
.