Skip to content

Conversation

renefloor
Copy link
Contributor

Submit a pull request

Linear: fixes FLU-142

Github Issue: fixes #2218

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

We have a null check operator on connectionCompleter. This can only be null if there is a disconnect while fetching a token. Now we return the connectionCompleter future before we go async, so this should never happen anymore.

We didn't reproduce it, so it's also hard to test.

@renefloor renefloor changed the title Fix null check on websocket connection fix(llc): null check on websocket connection May 20, 2025
@renefloor renefloor force-pushed the fix/null-check-in-websocket-connection branch from ac56032 to d1ff6b6 Compare May 20, 2025 14:32
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.28%. Comparing base (ec653d0) to head (d1ff6b6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2260   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files         404      404           
  Lines       25268    25270    +2     
=======================================
+ Hits        15990    15992    +2     
  Misses       9278     9278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xsahil03x xsahil03x merged commit f4ee46b into master May 20, 2025
16 checks passed
@xsahil03x xsahil03x deleted the fix/null-check-in-websocket-connection branch May 20, 2025 15:24
shiftflop pushed a commit to shiftflowinc/stream-chat-flutter that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Null check operator used on a null value
2 participants