Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have default reaction emojis match between iOS/Android and Web sdks. #1437

Closed
jmckenney opened this issue Mar 4, 2022 · 3 comments · Fixed by #1947
Closed

Have default reaction emojis match between iOS/Android and Web sdks. #1437

jmckenney opened this issue Mar 4, 2022 · 3 comments · Fixed by #1947
Labels
feature New capability released

Comments

@jmckenney
Copy link

Motivation
Clarity in communication between consumers/applications.

Proposed solution
Change the web sdk options to better match iOS/Android or vice versa.

Acceptance Criteria
GIVEN I click reactions to choose for a message
WHEN I am in either iOS/Android/Web
THEN I see the same number of emojis and they match as close as possible

GIVEN I click reactions to choose
WHEN I am on WEB
THEN I do not see the angry emoji since that is not on the iOS/Android list of reactions

👎 on iOS is 😢 on web
❗❓ on iOS is 😮 on web
😠 on web is not seen on iOS/Android
@jmckenney jmckenney added the feature New capability label Mar 4, 2022
@jmckenney
Copy link
Author

When attempting to follow instructions here: https://getstream.io/chat/docs/sdk/react/custom-code-examples/reactions/
I'm finding it very difficult to get objects that end up showing the emojis that I want that also match correctly to iOS and show the correct numbers relative to those already chosen via iOS.

@zacheryconverse
Copy link
Contributor

Hi @jmckenney,

Thanks for your feature request. We'll discuss this and get back to you soon.

@arnautov-anton arnautov-anton mentioned this issue Nov 15, 2023
Merged
arnautov-anton added a commit that referenced this issue Nov 27, 2023
@arnautov-anton
fix(emoji-mart): new reactions (#1947)
83f31da 
BREAKING CHANGE: `reactionOptions` signature has changed, see release
guide for more information

### 🎯 Goal

Refactor and fix the way reactions work, introduce new way of
customizing with better DX.

Fixes: #1935
Closes: #1637
Closes: #1437
Closes: #2159
Closes:
GetStream/stream-chat-react-native#2023

### 🛠 Implementation details

- ditch EmojiMart implementation, use native/sprite-sheet solution
arnautov-anton added a commit that referenced this issue Nov 27, 2023
@arnautov-anton
fix(emoji-mart): new reactions (#1947)
58ea978 
BREAKING CHANGE: `reactionOptions` signature has changed, see [release
guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information

Refactor and fix the way reactions work, introduce new way of
customizing with better DX.

Fixes: #1935
Closes: #1637
Closes: #1437
Closes: #2159
Closes:
GetStream/stream-chat-react-native#2023

- ditch EmojiMart implementation, use native/sprite-sheet solution
arnautov-anton added a commit that referenced this issue Nov 27, 2023
@arnautov-anton
fix(emoji-mart): new reactions (#1947)
14bef23 
Refactor and fix the way reactions work, introduce new way of
customizing with better DX.

Fixes: #1935
Closes: #1637
Closes: #1437
Closes: #2159
Closes:
GetStream/stream-chat-react-native#2023

- ditch EmojiMart implementation, use native/sprite-sheet solution

BREAKING CHANGE: `reactionOptions` signature has changed, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
github-actions bot pushed a commit that referenced this issue Nov 27, 2023
@semantic-release-bot
chore(release): 11.0.0 [skip ci]
a9a5193 
## [11.0.0](v10.20.1...v11.0.0) (2023-11-27)

### ⚠ BREAKING CHANGES

* **emoji-mart:** `EmojiPicker` & `EmojiIndex` signatures changed, `EmojiIndex` has been renamed to `emojiSearchIndex`, both `EmojiPicker` & `emojiSearchIndex` are now optional, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
* **emoji-mart:** `useImageFlagEmojisOnWindow` flag now requires extra style sheet import, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
* **emoji-mart:** `reactionOptions` signature has changed, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
* the first argument to `doSendMessageRequest` is now Channel instance instead of `Channel.cid`
* apply the remark plugins `keepLineBreaksPlugin`, `htmlToTextPlugin` as a part of the default message text parsing, upgrade `unified` libraries

### Bug Fixes

* **emoji-mart:** new reactions  ([#1947](#1947)) ([14bef23](14bef23)), closes [#1935](#1935) [#1637](#1637) [#1437](#1437) [#2159](#2159)
* **emoji-mart:** simplify EmojiPicker & emojiSearchIndex ([#2117](#2117)) ([a6e0a87](a6e0a87)), closes [#2116](#2116) [#2094](#2094)

### Features

* apply keepLineBreaksPlugin & htmlToTextPlugin plugins to text rendering by default ([#2169](#2169)) ([e8047f2](e8047f2)), closes [#2170](#2170) [/github.com/GetStream/stream-chat-react/blob/f0bc7ba2532760cabb1db01e685a35bd3b0b64c5/src/components/Message/renderText/renderText.tsx#L158](https://github.com/GetStream//github.com/GetStream/stream-chat-react/blob/f0bc7ba2532760cabb1db01e685a35bd3b0b64c5/src/components/Message/renderText/renderText.tsx/issues/L158)
* export MessageListNotifications and LinkPreviewList components and component props ([#2181](#2181)) ([a5a7e5a](a5a7e5a))
* require Channel instance as the first argument to doSendMessageRequest ([#2171](#2171)) ([2a06b88](2a06b88))

### Chores

* **deps:** bump stream-chat from 8.14.0 to 8.14.2 ([#2179](#2179)) ([4e6a59d](4e6a59d))
* **deps:** bump stream-chat from 8.14.2 to 8.14.3 ([#2185](#2185)) ([3dd8dab](3dd8dab))
@stream-ci-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New capability released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(emoji-mart): new reactions GetStream/stream-chat-react
3 participants
@jmckenney @stream-ci-bot @zacheryconverse