fix(emoji-mart): new reactions #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
force-pushed
the
feat/reactions
branch
from
1cb3813
to
2899d72
Compare
MartinCupela
requested changes
Feb 20, 2023
arnautov-anton
force-pushed
the
feat/reactions
branch
from
4dbd8cc
to
d7f0297
Compare
szuperaz
reviewed
Feb 21, 2023
arnautov-anton
force-pushed
the
feat/reactions
branch
from
d7f0297
to
9ba333e
Compare
3 tasks
arnautov-anton
force-pushed
the
feat/reactions
branch
from
9ce1535
to
c45ff57
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1947 +/- ##
===========================================
+ Coverage 82.08% 82.18% +0.09%
===========================================
Files 260 262 +2
Lines 6386 6420 +34
Branches 1797 1794 -3
===========================================
+ Hits 5242 5276 +34
+ Misses 832 830 -2
- Partials 312 314 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
arnautov-anton
force-pushed
the
feat/reactions
branch
2 times, most recently
from
0fc8df1
to
2cbbad3
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
2 times, most recently
from
54f5614
to
fa15322
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
from
fa15322
to
e8a0414
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
from
e8a0414
to
fd25753
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1947 +/- ##
==========================================
+ Coverage 83.73% 83.75% +0.02%
==========================================
Files 314 316 +2
Lines 7161 7191 +30
Branches 2024 2019 -5
==========================================
+ Hits 5996 6023 +27
- Misses 831 832 +1
- Partials 334 336 +2 ☔ View full report in Codecov by Sentry. |
arnautov-anton
force-pushed
the
feat/reactions
branch
2 times, most recently
from
057f595
to
e0522bf
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
from
e0522bf
to
2ae2c0f
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
from
2ae2c0f
to
06394b3
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
from
06394b3
to
cd27d2f
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
from
cd27d2f
to
537fe17
Compare
arnautov-anton
changed the title
arnautov-anton
force-pushed
the
feat/reactions
branch
from
a790fc0
to
344dd5f
Compare
arnautov-anton
changed the title
arnautov-anton
changed the title
arnautov-anton
force-pushed
the
feat/reactions
branch
from
344dd5f
to
c87b0e2
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
from
29f0738
to
258de6f
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
4 times, most recently
from
e2645d6
to
b5c31e9
Compare
arnautov-anton
added
breaking
arnautov-anton
force-pushed
the
feat/reactions
branch
from
b5c31e9
to
9fd7278
Compare
arnautov-anton
force-pushed
the
feat/reactions
branch
from
9fd7278
to
8074d21
Compare
arnautov-anton
added a commit
that referenced
this pull request
Nov 27, 2023
BREAKING CHANGE: `reactionOptions` signature has changed, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information Refactor and fix the way reactions work, introduce new way of customizing with better DX. Fixes: #1935 Closes: #1637 Closes: #1437 Closes: #2159 Closes: GetStream/stream-chat-react-native#2023 - ditch EmojiMart implementation, use native/sprite-sheet solution
arnautov-anton
added a commit
that referenced
this pull request
Nov 27, 2023
Refactor and fix the way reactions work, introduce new way of customizing with better DX. Fixes: #1935 Closes: #1637 Closes: #1437 Closes: #2159 Closes: GetStream/stream-chat-react-native#2023 - ditch EmojiMart implementation, use native/sprite-sheet solution BREAKING CHANGE: `reactionOptions` signature has changed, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
## [11.0.0](v10.20.1...v11.0.0) (2023-11-27) ### ⚠ BREAKING CHANGES * **emoji-mart:** `EmojiPicker` & `EmojiIndex` signatures changed, `EmojiIndex` has been renamed to `emojiSearchIndex`, both `EmojiPicker` & `emojiSearchIndex` are now optional, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information * **emoji-mart:** `useImageFlagEmojisOnWindow` flag now requires extra style sheet import, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information * **emoji-mart:** `reactionOptions` signature has changed, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information * the first argument to `doSendMessageRequest` is now Channel instance instead of `Channel.cid` * apply the remark plugins `keepLineBreaksPlugin`, `htmlToTextPlugin` as a part of the default message text parsing, upgrade `unified` libraries ### Bug Fixes * **emoji-mart:** new reactions ([#1947](#1947)) ([14bef23](14bef23)), closes [#1935](#1935) [#1637](#1637) [#1437](#1437) [#2159](#2159) * **emoji-mart:** simplify EmojiPicker & emojiSearchIndex ([#2117](#2117)) ([a6e0a87](a6e0a87)), closes [#2116](#2116) [#2094](#2094) ### Features * apply keepLineBreaksPlugin & htmlToTextPlugin plugins to text rendering by default ([#2169](#2169)) ([e8047f2](e8047f2)), closes [#2170](#2170) [/github.com/GetStream/stream-chat-react/blob/f0bc7ba2532760cabb1db01e685a35bd3b0b64c5/src/components/Message/renderText/renderText.tsx#L158](https://github.com/GetStream//github.com/GetStream/stream-chat-react/blob/f0bc7ba2532760cabb1db01e685a35bd3b0b64c5/src/components/Message/renderText/renderText.tsx/issues/L158) * export MessageListNotifications and LinkPreviewList components and component props ([#2181](#2181)) ([a5a7e5a](a5a7e5a)) * require Channel instance as the first argument to doSendMessageRequest ([#2171](#2171)) ([2a06b88](2a06b88)) ### Chores * **deps:** bump stream-chat from 8.14.0 to 8.14.2 ([#2179](#2179)) ([4e6a59d](4e6a59d)) * **deps:** bump stream-chat from 8.14.2 to 8.14.3 ([#2185](#2185)) ([3dd8dab](3dd8dab))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
reactionOptionssignature has changed, see release guide for more information🎯 Goal
Refactor and fix the way reactions work, introduce new way of customizing with better DX.
Fixes: #1935
Closes: #1637
Closes: #1437
Closes: #2159
Closes: GetStream/stream-chat-react-native#2023
🛠 Implementation details