Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: update react-player to its latest version #1626

Closed
oliverlaz opened this issue Jun 13, 2022 · 1 comment · Fixed by #1629
Closed

bug: update react-player to its latest version #1626

oliverlaz opened this issue Jun 13, 2022 · 1 comment · Fixed by #1629
Assignees
@oliverlaz
Labels
bug Something isn't working released status:confirmed Described issue has been reproduced by the repo maintainer

Comments

@oliverlaz
Copy link
Member

Describe the bug

When using React 18 StrictMode in dev mode, channels which have messages with video attachments (ex.: Youtube) emit many warnings in the browser's console. Player functionality isn't affected.

To Reproduce

Steps to reproduce the behavior:

  1. Send a Youtube video in a Channel

Expected behavior

react-player shouldn't emit these warnings.

Screenshots

Related issue in the library itself: cookpete/react-player#1439

Package version

  • stream-chat-react: 9.1.1
  • stream-chat-css: 2.10.0
  • stream-chat-js: 6.6.0
@oliverlaz oliverlaz added bug Something isn't working status:confirmed Described issue has been reproduced by the repo maintainer labels Jun 13, 2022
@oliverlaz oliverlaz self-assigned this Jun 13, 2022
@oliverlaz oliverlaz mentioned this issue Jun 14, 2022
Merged
oliverlaz added a commit that referenced this issue Jun 16, 2022
@oliverlaz
fix: upgrade react-player to its latest version (#1629)
8848700 
Updates react-player to v2.10.1, a version which fixes the problem with excessive logging when using React v18 in StrictMode. Closes: #1626.
@petyosi
Copy link
Contributor

petyosi commented Jun 19, 2022

🎉 This issue has been resolved in version 9.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverlaz oliverlaz

Labels
bug Something isn't working released status:confirmed Described issue has been reproduced by the repo maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: upgrade react-player to its latest version GetStream/stream-chat-react
2 participants
@petyosi @oliverlaz