feat: upgrade react-player to its latest version #1629
Merged
+27
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Updates
react-player
tov2.10.1
, a version which fixes the problem with excessive logging when using React v18 inStrictMode
. Closes: #1626.🛠 Notes
react-player@2.10.1
currently has one known issue which prevents certain events (onProgress
) from firing indevelopment
mode when using React v18StrictMode
. We don't use these events in our SDK codebase but a customer of ours can be using them if they opted into overriding the defaultAttachmentProps.Media
component. In that case, our customers would have to explicitly pin their dependency towardsreact-player
or temporary disableStrictMode
.This problem only occurs in development mode.