Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade react-player to its latest version #1629

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

oliverlaz
Copy link
Member

🎯 Goal

Updates react-player to v2.10.1, a version which fixes the problem with excessive logging when using React v18 in StrictMode. Closes: #1626.

🛠 Notes

react-player@2.10.1 currently has one known issue which prevents certain events (onProgress) from firing in development mode when using React v18 StrictMode. We don't use these events in our SDK codebase but a customer of ours can be using them if they opted into overriding the default AttachmentProps.Media component. In that case, our customers would have to explicitly pin their dependency towards react-player or temporary disable StrictMode.
This problem only occurs in development mode.

@oliverlaz oliverlaz merged commit 8848700 into develop Jun 16, 2022
@oliverlaz oliverlaz deleted the fix/upgrade-react-player branch June 16, 2022 12:06
@MartinCupela MartinCupela mentioned this pull request Jun 19, 2022
github-actions bot pushed a commit that referenced this pull request Jun 19, 2022
## [9.1.3](v9.1.2...v9.1.3) (2022-06-19)

### Bug Fixes

* correct calculation of scrollback with date separators ([#1628](#1628)) ([88a4d64](88a4d64))
* upgrade react-player to its latest version ([#1629](#1629)) ([8848700](8848700))
@petyosi
Copy link
Contributor

petyosi commented Jun 19, 2022

🎉 This PR is included in version 9.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: update react-player to its latest version
4 participants