fix(SelectionList): input text now selected on focus

ISSUES CLOSED: #1728
GetTerminus · Oct 3, 2019 · cbf4c8e · cbf4c8e
1 parent 5986191
commit cbf4c8e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/demo/app/components/selection-list/selection-list.component.ts b/demo/app/components/selection-list/selection-list.component.ts
@@ -33,8 +33,8 @@ export class SelectionListComponent implements OnInit, OnDestroy {
   public states = STATES.slice();
 
   // FormControls
-  public complexMultipleControl = new FormControl();
-  public simpleControl = new FormControl();
+  public complexMultipleControl = new FormControl('');
+  public simpleControl = new FormControl('');
 
   // Query controls
   public complexMultipleQuery$ = new BehaviorSubject('');

diff --git a/terminus-ui/selection-list/src/selection-list.component.html b/terminus-ui/selection-list/src/selection-list.component.html
@@ -35,6 +35,7 @@
           [readonly]="isDisabled ? 'true' : null"
           (ngModelChange)="querySubject.next($event)"
           (blur)="handleInputBlur($event)"
+          onfocus="this.select()"
           #input
         />
       </ts-chip-collection>
@@ -53,6 +54,7 @@
         [value]="searchQuery"
         (ngModelChange)="querySubject.next($event)"
         (blur)="handleInputBlur($event)"
+        onfocus="this.select()"
         #input
       />
 

diff --git a/terminus-ui/selection-list/src/selection-list.component.spec.ts b/terminus-ui/selection-list/src/selection-list.component.spec.ts
@@ -985,4 +985,8 @@ describe(`TsSelectionListComponent`, function() {
     expect(instance.panel.keyManager.activeItemIndex).toEqual(0);
   }));
 
+  // TODO: Not currently supported by Jest
+  //   Waiting for https://github.com/jsdom/jsdom/issues/317 to land
+  test.todo(`should select all existing text when the input is focused`);
+
 });