Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectionList: Focusing the input should select the entire text #1728

Closed
2 tasks
benjamincharity opened this issue Oct 1, 2019 · 0 comments · Fixed by #1732
Closed
2 tasks

SelectionList: Focusing the input should select the entire text #1728

benjamincharity opened this issue Oct 1, 2019 · 0 comments · Fixed by #1732
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Oct 1, 2019 •
edited
Loading

Currently, clicking into the single-mode version just places the cursor at the end of the input text rather than selecting it all which causes more work than necessary if the user wants to change the value.

Note: When tabbing to the single mode, all text is selected - just not when clicking into it.

  • When user focuses the list in single mode, all the input text should be highlighted.
  • Add test

Resources
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist labels Oct 1, 2019
@benjamincharity benjamincharity mentioned this issue Oct 1, 2019
Closed
2 tasks
benjamincharity added a commit that referenced this issue Oct 3, 2019
@benjamincharity
fix(SelectionList): input text now selected on focus
cbf4c8e 
ISSUES CLOSED: #1728
@benjamincharity benjamincharity changed the title SelectionList: Focusing the input in single mode should select the entire text SelectionList: Focusing the input should select the entire text Oct 3, 2019
@benjamincharity benjamincharity mentioned this issue Oct 3, 2019
Merged
benjamincharity added a commit that referenced this issue Oct 3, 2019
@benjamincharity
fix(SelectionList): input text now selected on focus
5a7ecb9 
ISSUES CLOSED: #1728
benjamincharity added a commit that referenced this issue Oct 3, 2019
@benjamincharity
fix(SelectionList): input text now selected on focus
10f2c89 
ISSUES CLOSED: #1728
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: feature Functionality that doesn't currently exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1728 selectionlist select text GetTerminus/terminus-ui
1 participant
@benjamincharity