Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select: Shift+Arrow should select multiple items but is not working #1227

Closed
2 tasks
benjamincharity opened this issue Jan 16, 2019 · 0 comments
Closed
2 tasks

Select: Shift+Arrow should select multiple items but is not working #1227

benjamincharity opened this issue Jan 16, 2019 · 0 comments
Assignees
@shani-terminus
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Jan 16, 2019 •
edited
Loading

When focused on a multiple select, the user should be able to hold down SHIFT and use the UP|DOWN arrow keys to also select adjacent options in a single direction.

Currently the test for this is commented out since the functionality seems to be broken.

  • Add/verify functionality
  • Add/enable test(s)
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects labels Jan 16, 2019
@shani-terminus shani-terminus self-assigned this Mar 11, 2019
shani-terminus added a commit that referenced this issue Mar 14, 2019
@shani-terminus
fix(Select): shift+arrow will select multiple
6ba56fd 
ISSUES CLOSED: #1227
@shani-terminus shani-terminus mentioned this issue Mar 14, 2019
Merged
benjamincharity pushed a commit that referenced this issue Mar 15, 2019
@shani-terminus @benjamincharity
fix(Select): shift+arrow will select multiple
89651e7 
ISSUES CLOSED: #1227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamincharity @shani-terminus