Skip to content

fix(Select): shift+arrow will select multiple #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2019

Conversation

shani-terminus
Copy link
Contributor

Also cleaned up the imports by removing the ones we aren't using.

ISSUES CLOSED: #1227

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #1413 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
+ Coverage   99.38%   99.43%   +0.05%     
==========================================
  Files         101      101              
  Lines        3747     3748       +1     
  Branches      555      555              
==========================================
+ Hits         3724     3727       +3     
+ Misses         23       21       -2
Impacted Files Coverage Δ
terminus-ui/select/src/select.component.ts 97.09% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7273c...6ba56fd. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #1413 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1413      +/-   ##
==========================================
+ Coverage   99.38%   99.43%   +0.05%     
==========================================
  Files         101      101              
  Lines        3747     3748       +1     
  Branches      555      554       -1     
==========================================
+ Hits         3724     3727       +3     
+ Misses         23       21       -2
Impacted Files Coverage Δ
terminus-ui/select/src/select.component.ts 97.09% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea7273c...ce53da1. Read the comment docs.

@benjamincharity benjamincharity merged commit 756907c into master Mar 15, 2019
@benjamincharity benjamincharity deleted the 1227-Select-keyboard-select-multiple branch March 29, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants