Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove karma & jasmine from the Demo #1412

Closed
3 of 4 tasks
benjamincharity opened this issue Mar 13, 2019 · 0 comments · Fixed by #1545
Closed
3 of 4 tasks

Remove karma & jasmine from the Demo #1412

benjamincharity opened this issue Mar 13, 2019 · 0 comments · Fixed by #1545
Assignees
@shani-terminus
Labels
Focus: build Issues concerning our CI or build process' Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Mar 13, 2019 •
edited by shani-terminus
Loading

Consumers are now all on Jest so we no longer need to support Karma & Jasmine in the demo.

  • Remove all packages related to Karma/Jasmine
  • Remove all related files
  • Remove all related references
  • Set up single jest test for demo app so we can verify it works
    • This test should use a testing tool from the library
@benjamincharity benjamincharity added Focus: build Issues concerning our CI or build process' Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition labels Mar 13, 2019
@benjamincharity benjamincharity changed the title Remove karma & jasmine Remove karma & jasmine from the Demo May 1, 2019
shani-terminus added a commit that referenced this issue Jun 6, 2019
@shani-terminus
chore(Demo): remove karma and jasmine
4311e17 
to test demo, run \`yarn run test:demo\`

ISSUES CLOSED: #1412
@shani-terminus shani-terminus mentioned this issue Jun 6, 2019
Merged
shani-terminus added a commit that referenced this issue Jun 11, 2019
@shani-terminus
chore(Demo): remove karma and jasmine
d26c8a4 
to test demo, run \`yarn run test:demo\`

ISSUES CLOSED: #1412
benjamincharity pushed a commit that referenced this issue Jun 13, 2019
@shani-terminus @benjamincharity
chore(Demo): remove karma and jasmine
62a2ae8 
to test demo, run \`yarn run test:demo\`

ISSUES CLOSED: #1412
benjamincharity pushed a commit that referenced this issue Jun 13, 2019
@shani-terminus @benjamincharity
chore(Demo): remove karma and jasmine
3c0106c 
to test demo, run \`yarn run test:demo\`

ISSUES CLOSED: #1412
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shani-terminus shani-terminus

Labels
Focus: build Issues concerning our CI or build process' Target: latest Issues related to the latest version of the library (master) Type: chore Something that needs to be done but is not a bug or addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(Demo): remove karma and jasmine GetTerminus/terminus-ui
2 participants
@benjamincharity @shani-terminus